-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update poetry requirement from <=1.2.0,>=1.1.15 to >=1.1.15,<1.3.0 in /python/helpers #5746
Update poetry requirement from <=1.2.0,>=1.1.15 to >=1.1.15,<1.3.0 in /python/helpers #5746
Conversation
67cd04c
to
93f1f94
Compare
Test failure: https://github.com/dependabot/dependabot-core/actions/runs/3084706530/jobs/4989361093 I can't quite figure out what that diff is trying to tell me, but given that a hash is shown in red, I suspect might be related to python-poetry/poetry#6389 in which case we just need to update expected test output. However, I may be misunderstanding, as I've never really looked into how these smoke tests are generating expected vs actual, so will need to do a little more digging before proceeding... |
If you look at the Diff step right after the failed one, it gives you another view of what has changed. I have rerun with a new version of the CLI that fixes a minor issue, so that DIff step shows: 366d365
< {file = "toml-0.10.0-py2.[7](https://github.com/dependabot/dependabot-core/actions/runs/3084706530/jobs/4989361093#step:9:8).egg", hash = "sha256:f1db651f9657708513243e61e6cc67d101a39bad662eaa9b5546f789338e07a3"}, So that's saying this line has been removed due to the Poetry bump. That looks like just a result of Poetry changing versions and not some other issue, so we'll need to update the test either before or after merge to remove that line to get the tests passing again. |
93f1f94
to
5dd99b1
Compare
`poetry` `1.2.1` no longer generates this line that was present in `1.2.0`. I'm not 100% positive, but I _think_ that might be the result of python-poetry/poetry#6389. Details here: dependabot/dependabot-core#5746 (comment)
Merging this. I put up the test fix, but it's in a different repo so there's a two-step dance either way, and _jakecoffman wisely suggested merging here first and watching how it works in prod... so that if we need to rollback we only rollback in one repo and not two. |
5dd99b1
to
1cf4cd5
Compare
@dependabot rebase |
Updates the requirements on [poetry](https://github.com/python-poetry/poetry) to permit the latest version. - [Release notes](https://github.com/python-poetry/poetry/releases) - [Changelog](https://github.com/python-poetry/poetry/blob/master/CHANGELOG.md) - [Commits](python-poetry/poetry@1.1.15...1.2.1) --- updated-dependencies: - dependency-name: poetry dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
1cf4cd5
to
3b79250
Compare
Updates the requirements on poetry to permit the latest version.
Release notes
Sourced from poetry's releases.
Changelog
Sourced from poetry's changelog.
... (truncated)
Commits
7cd761a
release: bump version to 1.2.1f47f2aa
fix(cache clear): normalize package namefc4bc0c
fix: wrong nested table level when overwriting pyproject (#6512)f6cce31
build(deps): bumpdulwich
to0.20.46
3202859
fix: poetry-core>=1.1.0 is needed as build-system requirementbacef6a
[1.2] docs: added note aboutpre-commit autoupdate
(#6502)5535e13
[1.2] Add missing deprecation warning for--dev
(#6493)22741bb
Clarify removal for non-installed extras & optional groups (#6229)b5b7843
respect --no-cache at poetry install7d09bc5
[1.2] docs: improved description ofvirtualenvs.create
option (#6469)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)