Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo: handle unsupported toolchain versions (part 2) #7168

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

jakecoffman
Copy link
Member

This is the same PR as #7122 but against the version resolver.

It would probably be good in the future to create a native helper that both the version resolver and lockfile updater use since the errors seem like they are the same between the two.

@jakecoffman jakecoffman requested a review from a team as a code owner April 25, 2023 15:08
@github-actions github-actions bot added the L: rust:cargo Rust crates via cargo label Apr 25, 2023
@jeffwidman
Copy link
Member

It would probably be good in the future to create a native helper that both the version resolver and lockfile updater use since the errors seem like they are the same between the two.

Why not wrap the calls to cargo in a custom ruby class / function that handles common errors? And use that both places?

Native helpers can be useful some places, but IMO the simplicity of using the package manager's CLI is tough to beat, especially because users are generally using it as the reference for expected behavior and we don't have to futz around with building, keeping internal API's updated, etc.

@jeffwidman jeffwidman merged commit 7436114 into main Apr 25, 2023
@jeffwidman jeffwidman deleted the jakecoffman/cargo-sparse-registry-part-2 branch April 25, 2023 16:36
@jakecoffman
Copy link
Member Author

@jeffwidman Sorry that's what I meant! In Bundler we have a module called NativeHelpers that's what I was referring to even though I wrote "native helper" 🤦 . NativeHelperHelper maybe?

@abdulapopoola abdulapopoola added the T: bug 🐞 Something isn't working label Apr 25, 2023
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
This is the same PR as dependabot#7122 but against the version resolver. 

It would probably be good in the future to create a native helper that both the version resolver and lockfile updater use since the errors seem like they are the same between the two.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: rust:cargo Rust crates via cargo T: bug 🐞 Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants