Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accidentally committed node_modules folders #7172

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

I think these folders must've been committed by mistake?

Copy link
Member

@landongrindheim landongrindheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩸🩸🩸 😵‍💫 🩸🩸🩸

@jakecoffman
Copy link
Member

The root .gitignore has /node_modules, should that be node_modules/?

@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/remove-unused-fixtures branch from d9b19a2 to 766148a Compare April 26, 2023 18:30
@deivid-rodriguez
Copy link
Contributor Author

Awesome catch @jakecoffman! I changed the .gitignore file to disallow all node_modules/!

@landongrindheim
Copy link
Member

Awesome catch @jakecoffman! I changed the .gitignore file to disallow all node_modules/!

While a much better solution, this blood diff is 🤏 less impressive now 🙃
image

Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this. 🎉

@jeffwidman jeffwidman force-pushed the deivid-rodriguez/remove-unused-fixtures branch from 766148a to 2b221e1 Compare April 27, 2023 17:14
@jeffwidman jeffwidman enabled auto-merge (squash) April 27, 2023 17:15
@jeffwidman jeffwidman merged commit 310f308 into main Apr 27, 2023
@jeffwidman jeffwidman deleted the deivid-rodriguez/remove-unused-fixtures branch April 27, 2023 17:25
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
* Remove accidentally committed `node_modules` folders

* Fix `.gitignore` to properly disallow all `node_modules/`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants