Improve naming of a method #7197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Apr 28, 2023
Since we have `ignore` settings, this may lead code reader into thinking we actually support skipping lockfiles through `dependabot.yml`. This is just trying to respect a package manager specific setting, so let's rename it to reduce confusion.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/improve-lockfile-skip-method
branch
from
ea8a54a
to
d0bbc6b
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/improve-lockfile-skip-method
branch
Merged
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
Since we have `ignore` settings, this may lead code reader into thinking we actually support skipping lockfiles through `dependabot.yml`. This is just trying to respect a package manager specific setting, so let's rename it to reduce confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have
ignoresettings, this may lead code reader into thinking we actually support skipping lockfiles throughdependabot.yml. This is just trying to respect a package manager specific setting, so let's rename it to reduce confusion.Suggested by @jeffwidman at #7081 (comment).