Remove unused GH_TOKEN env var
#7207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulapopoola
approved these changes
May 1, 2023
|
does the token need to be removed from the secrets store too? |
In this case no:
Also it's set to |
`GH_TOKEN` is necessary when using the `gh` CLI. We use this in `images-branch.yml` when doing some stuff around forks, but not here in `images-latest.yml`. I considered leaving it for consistency, and in case we ever add back `gh`. But the consistency arg doesn't make sense since `images-updater-core.yml` doesn't have this. And if we add back `gh`, we'll get an obvious error message about the problem per github/docs#21930 (comment).
jeffwidman
force-pushed
the
remove-unused-env-var
branch
from
0472245
to
837dd86
Compare
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
`GH_TOKEN` is necessary when using the `gh` CLI. We use this in `images-branch.yml` when doing some stuff around forks, but not here in `images-latest.yml`. I considered leaving it for consistency, and in case we ever add back `gh`. But the consistency arg doesn't make sense since `images-updater-core.yml` doesn't have this. And if we add back `gh`, we'll get an obvious error message about the problem per github/docs#21930 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH_TOKENis necessary when using theghCLI.We use
ghover inimages-branch.ymlwhen doing some stuff around forks, but not here inimages-latest.yml.I considered leaving it for consistency, and in case we ever add back
gh. But the consistency arg doesn't make sense sinceimages-updater-core.ymldoesn't have this. And if we add backgh, we'll get an obvious error message about the problem per github/docs#21930 (comment).