Catch bundle lock failures
#7208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `bundle lock` failed for some reason, then the exit code wasn't preserved and the message about the gemfile being updated successfully was incorrectly printed.
jeffwidman
force-pushed
the
catch-bundle-lock-failures
branch
from
5782223
to
8bf31bd
Compare
mctofu
approved these changes
May 1, 2023
jeffwidman
added
build 🛠
jeffwidman
commented
May 1, 2023
| @@ -28,6 +28,10 @@ | |||
|
|
|||
| # Bump the updater's Gemfile.lock with the new version | |||
| `cd updater/ && bundle lock` | |||
| if $?.exitstatus | |||
There was a problem hiding this comment.
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
If `bundle lock` failed for some reason, then the exit code wasn't preserved and the message about the gemfile being updated successfully was incorrectly printed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
bundle lockfailed for some reason, then the exit code wasn't preserved and the message about the gemfile being updated successfully was incorrectly printed.Related: