Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a method missing error distracting when we hit any unhandled exceptions #7287

Merged
merged 2 commits into from
May 11, 2023

Conversation

brrygrdn
Copy link
Contributor

I overzealously pruned methods from UpdateFilesCommand which resulted in unhandled errors hitting a problem where base_commit_sha wasn't defined making for some distracting traces, e.g.

 Dependabot encountered '1' error(s) during execution, please check the logs for more details.
updater | +---------------+
updater | |    Errors     |
updater | +---------------+
updater | | unknown_error |
updater | +---------------+
updater | /home/dependabot/dependabot-updater/lib/dependabot/base_command.rb:42:in `base_commit_sha': NotImplementedError (NotImplementedError)
updater | 	from /home/dependabot/dependabot-updater/lib/dependabot/base_command.rb:56:in `rescue in run'
updater | 	from /home/dependabot/dependabot-updater/lib/dependabot/base_command.rb:54:in `run'
updater | 	from bin/update_files.rb:23:in `<main>'
updater | /home/dependabot/dependabot-updater/lib/dependabot/updater/group_dependency_file_batch.rb:40:in `block in merge': undefined method `path' for nil:NilClass (NoMethodError)
updater | 
updater |                            Dependabot.logger.debug("Updated an unexpected file at '#{existing_file.path}'")
updater |                                                                                                   ^^^^^
...

@brrygrdn brrygrdn requested a review from a team as a code owner May 10, 2023 18:19
Base automatically changed from brrygrdn/fix-vendored-file-crash to main May 10, 2023 18:38
@brrygrdn brrygrdn force-pushed the brrygrdn/fix-missing-method branch from d5294a9 to 5b2752c Compare May 10, 2023 18:44
@brrygrdn brrygrdn enabled auto-merge May 11, 2023 08:32
@brrygrdn brrygrdn merged commit e87a102 into main May 11, 2023
@brrygrdn brrygrdn deleted the brrygrdn/fix-missing-method branch May 11, 2023 08:36
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
…ng-method

Avoid a method missing error distracting when we hit any unhandled exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants