Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we start from main even if workflow run from a branch #7335

Merged
merged 1 commit into from
May 17, 2023

Conversation

jeffwidman
Copy link
Member

@jeffwidman jeffwidman commented May 17, 2023

I kept having problems while testing #7324 until I realized that because I was doing my testing on a branch, actions/checkout was starting from the branch and then opening a PR against main, so it included not only the commit generated within this workflow, but also whatever other commits I'd made during my testing.

For this particular workflow, we always want to start from main as we're building a PR that should only contain the version bump commit.

Related:

I kept having problems while testing #7324
until I realized that because I was doing my testing on a branch,
`actions/checkout` was starting from the branch and then opening a PR
against `main`, so it included not only the commit generated within this
workflow, but also whatever other commits I'd made during my testing.

For this particular workflow, we always want to start from `main` as
we're building a PR that should only contain the version bump commit.
@jeffwidman jeffwidman merged commit 2d23b3c into main May 17, 2023
@jeffwidman jeffwidman deleted the always-checkout-from-main branch May 17, 2023 09:37
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
…dabot#7335)

I kept having problems while testing dependabot#7324
until I realized that because I was doing my testing on a branch,
`actions/checkout` was starting from the branch and then opening a PR
against `main`, so it included not only the commit generated within this
workflow, but also whatever other commits I'd made during my testing.

For this particular workflow, we always want to start from `main` as
we're building a PR that should only contain the version bump commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants