Report release to sentry #8885
Report release to sentry #8885
Conversation
deivid-rodriguez
force-pushed
the
deivid-rodriguez/report-release-to-sentry
branch
from
6054b28 to
fd76f70
Compare
deivid-rodriguez
force-pushed
the
deivid-rodriguez/report-release-to-sentry
branch
4 times, most recently
from
8a7ebbb to
eb8ac52
Compare
|
Sounds like the updater SHA is not getting passed correctly, needs some debugging. Passing "release" as a tag seems to work though. |
|
Can I merge #8878 first please? |
|
Of course, I actually tried this in staging and saw "development" being reported as the release, which is unexpected! So it's currently marked as WIP and I'll hold working on it at least until your migration is done 👍. |
|
Thanks! You are good to go. |
Nishnha
force-pushed
the
deivid-rodriguez/report-release-to-sentry
branch
from
eb8ac52 to
5d11d63
Compare
|
It looks like it's using the default
I think it's because the "prepare tag" and "prepare tag (fork)" steps are both getting skipped and that's where we pass the value to the GITHUB_ENV. We are missing the case where the workflow was triggered by a pull request review
|
Fixes #8885 (comment) where our sentry releases are still reporting the default value of "development" instead of the build SHA. We were passing in the DEPENDABOT_UPDATER_VERSION env as a build arg but referencing it as an ENV in docker. Let's update these to match https://docs.docker.com/reference/cli/docker/container/run/#env
* Pass in dependabot_updater_version as env Fixes #8885 (comment) where our sentry releases are still reporting the default value of "development" instead of the build SHA. We were passing in the DEPENDABOT_UPDATER_VERSION env as a build arg but referencing it as an ENV in docker. Let's update these to match https://docs.docker.com/reference/cli/docker/container/run/#env * Pass the build arg to a docker env
|
Yep @Nishnha, I observed the same thing and marked this PR as WIP because of that. Awesome that you managed to fix the root cause 💪 ❤️ |
To better catch regressions.