Fix hardcoded amd64 arch for git-shim #9067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, that's interesting as building a local ARM image has been working for me. I wonder how! |
jakecoffman
approved these changes
Feb 16, 2024
It might be something to do with docker-desktop on macos and it's virtualisation + rosetta. The issue that caused me to see this happened during runtime when executing on linux arm environment. Edit: See this comment which is where the problem got reported: https://gitlab.com/dependabot-gitlab/dependabot/-/issues/393#note_1776268031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
TARGETARCHargument similar to updater images to prevent havingamd64binary ofgit-shimwhen building arm image