-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flag security alerts and pass versions through #144
Conversation
I still need to add test coverage to the new |
Updated documentation and addressed unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you ❤️
I have one thought that might be a bit defensive. This is adds a call to the GitHub API that might be wasted if users don't care about these values - should we use an input
flag, which defaults to false
to ensure the query is only invoked when explicitly requested? 🤔
I love this pattern of using the API to enrich the metadata further, but it might be worth setting a precedent of doing the least work by default.
Yes, that makes perfect sense - I'll add that and assign it back for review |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @mwaddell! I just want to do a minor release to get some house keeping updates out of the way and I'll get this merged 🚀
closes #84
closes #102