Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an OSX workaround for sed in bump-version #171

Closed
wants to merge 1 commit into from
Closed

Add an OSX workaround for sed in bump-version #171

wants to merge 1 commit into from

Conversation

brrygrdn
Copy link
Contributor

OSX doesn't tolerate -i without passing a blank argument. I think this is ok on 'nix but I could use a double-check.

@brrygrdn brrygrdn requested a review from a team as a code owner February 28, 2022 18:35
@mwaddell
Copy link
Contributor

Passing the blank argument blows up on Linux. You can either do:

sed -i.bak "s|dependabot/fetch-metadata@v[0-9.]*|dependabot/fetch-metadata@v${new_version}|g" "README.md"
rm README.md.bak

or if sed with in-place editing is not well supported across platforms, we could use PERL:

perl -pi -e "s/dependabot\/fetch-metadata\@v[0-9.]*/dependabot\/fetch-metadata\@v${new_version}/g" "README.md"

@brrygrdn
Copy link
Contributor Author

Ah, cheers I hadn't had a chance to check on a VM. I'll update 👍🏻

@brrygrdn brrygrdn mentioned this pull request Apr 19, 2022
Merged
@brrygrdn brrygrdn closed this Apr 19, 2022
@brrygrdn
Copy link
Contributor Author

This is now fixed in #205

@jeffwidman jeffwidman deleted the brrygrdn/bump-versions-osx-weird branch April 17, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brrygrdn @mwaddell