Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom JAVA_OPTS Environment Variable #145

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Saturate
Copy link
Collaborator

Before this change tl.setVariable would override any custom JAVA_OPTS, making it impossible to set Java memory as needed in #144

Will print if any non-default JAVA_OPTS are set, for better debugging, if nothing is defined it will use the default '-Xss8192k' as said before, so this is not a breaking change.

Fixes #131

Before this change `tl.setVariable` would override any custom JAVA_OPTS, making it impossible to set Java memory as needed in dependency-check#144

Fixes dependency-check#131
@Saturate Saturate requested a review from a team as a code owner November 27, 2023 16:52
@tlogik
Copy link
Collaborator

tlogik commented Nov 30, 2023

@ejohn20
I have tested this change together with @Saturate on our own Devops and it works like a breeze.
We are now able to set the JVM as we want to and also we can now do proper OWASP scans because we have created a local cache of the NIST files.
See https://github.com/jeremylong/Open-Vulnerability-Project/tree/main/vulnz#caching-the-nvd-cve-data for a guide for that.
So can we please get the PR approved, deployed so we are all able to move on and handle the downtime we currently see from the NIST servers.
Thanks @ejohn20

@tlogik
Copy link
Collaborator

tlogik commented Nov 30, 2023

@jeremylong @ejohn20
Can we do something to exepedite the PR somehow?
We have 100+ pipelines that are failing on OWASP and with this PR we can make them all work again!
We are internally at our organistation dependent on this extension and discussing if we can be part of maintaining this as well.
This would benefit all :-)

@tlogik
Copy link
Collaborator

tlogik commented Nov 30, 2023

Hi @ejohn20
I have attached a log from devops showing it works using our build of the template.
For testing we have bumped to v10 :-)
We are using our own downloaded CVE files as can be seen in the logs and also that it succeeds.
owasp_log.txt

@tlogik
Copy link
Collaborator

tlogik commented Dec 1, 2023

@ejohn20 sorry to be so pushy here but we really need to PR to either be approved, if it is good, so we can get all of our pipelines to work again.

Copy link
Collaborator

@ejohn20 ejohn20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ejohn20 ejohn20 merged commit 36945cf into dependency-check:main Dec 1, 2023
@ejohn20 ejohn20 mentioned this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment variable JAVA_OPTS is overwritten with hard coded settings.
3 participants