-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted tweaks #29
Assorted tweaks #29
Conversation
* fix repo URLs * specify the files to include * split npm scripts
@mrjoelkemp friendly ping :) I've made PRs in all node-precinct's dependencies and you should be able to cut new patch releases after this PR is addressed and I update the other packages to use the new version of node-source-walk in my PRs. |
Thank you! |
@mrjoelkemp I think this is broken, sorry about that. Getting failures on the other repos:
Trying to fix this as we speak. |
You should have permissions to push and publish fixes. Feel free. |
I'm not sure if it's a bug per se, being that and empty string is a string so the typeof check is passing (for example in node-detective-scss): module.exports = function detective(fileContent) {
if (typeof fileContent === 'undefined') throw new Error('content not given');
if (typeof fileContent !== 'string') throw new Error('content is not a string');
// ...
} Regardless, I think I'm going to revert the strict mode change and publish a patch version until I figure this out. |
I split and adapted the patches from #28 so that we can land this and have a patch version.
Test run: https://github.com/XhmikosR/node-source-walk/actions?query=branch%3Adev-1
/CC @mrjoelkemp