Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted tweaks #29

Merged
merged 9 commits into from
Feb 19, 2022
Merged

Assorted tweaks #29

merged 9 commits into from
Feb 19, 2022

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jan 22, 2022

I split and adapted the patches from #28 so that we can land this and have a patch version.

Test run: https://github.com/XhmikosR/node-source-walk/actions?query=branch%3Adev-1

/CC @mrjoelkemp

@XhmikosR
Copy link
Member Author

@mrjoelkemp friendly ping :)

I've made PRs in all node-precinct's dependencies and you should be able to cut new patch releases after this PR is addressed and I update the other packages to use the new version of node-source-walk in my PRs.

@mrjoelkemp mrjoelkemp merged commit e7010cb into dependents:master Feb 19, 2022
@mrjoelkemp
Copy link
Collaborator

@mrjoelkemp friendly ping :)

I've made PRs in all node-precinct's dependencies and you should be able to cut new patch releases after this PR is addressed and I update the other packages to use the new version of node-source-walk in my PRs.

Thank you!

@XhmikosR XhmikosR deleted the dev-1 branch February 19, 2022 16:11
@XhmikosR
Copy link
Member Author

@mrjoelkemp I think this is broken, sorry about that. Getting failures on the other repos:

     AssertionError [ERR_ASSERTION]: Got unwanted exception.
Actual message: "Cannot create property 'parent' on number '0'"

Trying to fix this as we speak.

@mrjoelkemp
Copy link
Collaborator

You should have permissions to push and publish fixes. Feel free.

@XhmikosR
Copy link
Member Author

I'm not sure if it's a bug per se, being that and empty string is a string so the typeof check is passing (for example in node-detective-scss):

module.exports = function detective(fileContent) {
  if (typeof fileContent === 'undefined') throw new Error('content not given');
  if (typeof fileContent !== 'string') throw new Error('content is not a string');
  // ...
}

Regardless, I think I'm going to revert the strict mode change and publish a patch version until I figure this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants