Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #17

Merged
merged 9 commits into from
Nov 30, 2024
Merged

Dev #17

merged 9 commits into from
Nov 30, 2024

Conversation

vinaymavi
Copy link
Member

This pull request focuses on refactoring the codebase to improve module imports and enhance service usage across various files. The changes mainly involve moving services to a shared module and updating import paths accordingly.

Refactoring and Code Improvements:

  • Updated import paths for S3Service to use the shared module across multiple files, including auth.controller.ts, aws.controller.ts, slides.controller.ts, video.controller.ts, api.runner.ts, runner.factory.ts, slides-audio.generator.ts, slides.runner.ts, video-recorder.module.ts, video.processor.ts, and video.worker.ts. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

  • Added AwsModule from the shared module to various files, including auth.module.ts, slides.module.ts, and video.module.ts. [1] [2] [3]

Testing and Configuration:

  • Included S3Service and FsService in the providers array for test files auth.controller.spec.ts, slides.controller.spec.ts, and video.controller.spec.ts. [1] [2] [3]

Deprecation Notices:

  • Added deprecation comments for SlidesController indicating it will be removed in the future.

Code Cleanup:

  • Added comments indicating that DynamodbClientService and SnsService are not in use and need to be removed. [1] [2]

Enhancements:

  • Enhanced the deleteVideo method in video.controller.ts to include additional cleanup operations for related assets.

@vinaymavi vinaymavi merged commit b923c9b into main Nov 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant