Skip to content

Commit

Permalink
moved symfony finder to dev-dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
@staabm
staabm authored Dec 14, 2017
1 parent 67f50a4 commit e6df0f2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@
"deployer/phar-update": "~2.0",
"pimple/pimple": "~3.0",
"symfony/console": "~2.7|~3.0",
"symfony/finder": "~2.7|~3.0",
"symfony/process": "~2.7|~3.0",
"symfony/yaml": "~2.7|~3.0"
},
"require-dev": {
"phpunit/phpunit": "~6.1"
"phpunit/phpunit": "~6.1",
"symfony/finder": "~2.7|~3.0"
},
"config": {
"sort-packages": true,
Expand Down

15 comments on commit e6df0f2

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonmedv Would you mind adding this to 4.x too and making a new 4.x release with this change?

This currently prevents us from updating other packages which require Symfony 4.1, since we still cannot update from Deployer 4.x (see #1387).

@antonmedv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Will do. You can't use symfony/finder? Can you open PR?

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem: #1702

Aside from that the next issue I've encountered is symfony/expression-language. Currently elfet/pure only supports ~2.6|~3.0 but we'll need ^4.1 ...

@antonmedv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see :) PR to pure too? :)

@staabm
Copy link
Contributor Author

@staabm staabm commented on e6df0f2 Sep 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbrodala I guess you would also need "~2.7|~3.0|~4.0" for the symfony/* dependencies in the require-section, don't you?

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@staabm No, that doesn't matter since require-dev is only loaded for Deployer as root package, not as dependency.

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonmedv

This repository has been archived by the owner. It is now read-only.

Also there is antonmedv/purephp#5 ...

@antonmedv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some really old stuff. :) If you can figure it out what to do, I'll merge it and release.

@staabm
Copy link
Contributor Author

@staabm staabm commented on e6df0f2 Sep 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that doesn't matter since require-dev is only loaded for Deployer as root package, not as dependency.

@mbrodala but what about all those other symfony dependencies (which are part of the require section)?

deployer/composer.json

Lines 33 to 35 in e6df0f2

"symfony/console": "~2.7|~3.0",
"symfony/process": "~2.7|~3.0",
"symfony/yaml": "~2.7|~3.0"

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@staabm They don't hit us personally ATM. ;-)

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonmedv I'll have a look.

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonmedv See https://github.com/antonmedv/purephp/compare/master...mbrodala:symfony-v3-v4?expand=1 At least the tests still run fine.

I cannot create a PR since the repository is readonly.

@antonmedv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged! https://github.com/antonmedv/purephp/releases/tag/v3.0.0
Can you now create PR with updated version to deployer?

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There you go: #1703.

Notice that I'm currently looking at deployer/dist instead to get out of this dependency issue. So far it's looking quite well.

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonmedv Can you also update elfet/pure on Packagist? Currently it still shows v2.0.0 as latest version.

Please sign in to comment.