Fix merge of string array config options #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unbreaks e.g. the following:
add('shared_files', ['foo']);
add('shared_files', ['bar']);
Without this fix, this would become ['bar'] instead of ['foo', 'bar']
mbrodala
referenced
this pull request
Mar 7, 2017
* Add (failing) tests for scalar option merge behavior * Fix scalar values on recursive option merge This covers the following two essential usecases: 1. A scalar default value should be overridden 2. Values should be added to a array default value * Update changelog * Add a few comments * Use specific class name for config merge
|
Thanks a lot. You save me this this PR. I give you contributor star ⭐️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unbreaks e.g. the following:
Without this fix, this would become
['bar']instead of['foo', 'bar'].