Properly handle input options

[kick-the-bucket]

Q	A
Bug fix?	Yes
New feature?	No
BC breaks?	No
Deprecations?	No
Fixed tickets	#1792 comment

[antonmedv]

Awesome!

[kick-the-bucket]

Looks like it's still handling the array options wrong in some edge cases, but I'll try to fix those as well.
Both nulls and empty strings are legal array-optional values and an empty string is a legal array-required value, but all these values are currently ignored/stripped from the original input.

[antonmedv]

@kick-the-bucket so? How it's going? Maybe delete declare(strict_types=1); if it helps?

[rvitaliy]

LGTM!
minor changes required, not mandatory

[rvitaliy]

@kick-the-bucket
I did a quick analysis
👍 both null and empty string in an array can be managed.
keep in mind that both will be transformed into empty string.
we can't pass null by command 😢

[kick-the-bucket]

@kick-the-bucket so? How it's going? Maybe delete declare(strict_types=1); if it helps?

The option handling issues are logical, rather than type-related, so sadly this won't help.
Option handling might have never been fully correct (it certainly never worked with array options)...

@rvitaliy I did find a way to pass null to both VALUE_OPTIONAL and VALUE_IS_ARRAY | VALUE_OPTIONAL- it has to be either:

• the last option in the list, with no equals sign or space following
• followed by a space (but no equals sign) and another option

So it looks like the only thing that needs to be done for null values is to remove the equals sign.

[antonmedv]

So, everything looks ok to me. @kick-the-bucket @rvitaliy merging?

And please update changelog by php bin/changelog command.

[rvitaliy]

InputOption::VALUE_REQUIRED
accept empty string but not null

[kick-the-bucket]

Looks like all possible options values are now being handled correctly which was probably never the case since the feature was implemented almost 3 years ago 😅

[rvitaliy]

LGTM 🍻