Update symfony4.php #1881
Merged
Update symfony4.php #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On SF 4.2+, the .env file is versionned, only the .env.local is not versionned anymore
antonmedv
reviewed
Jul 10, 2019
| @@ -10,7 +10,7 @@ | |||
| require_once __DIR__ . '/common.php'; | |||
|
|
|||
| set('shared_dirs', ['var/log', 'var/sessions']); | |||
| set('shared_files', ['.env']); | |||
| set('shared_files', ['.env.local']); | |||
There was a problem hiding this comment.
Will it break existing Symfony installations which are using this recipe?
There was a problem hiding this comment.
In facts, .env is versionned since Symfony 4.1.
Your configuration is ONLY for symfony 4.0 (https://symfony.com/doc/4.1/configuration/dot-env-changes.html) , and this version is not maintained anymore (https://symfony.com/roadmap)
So... yes it will maybe break existing symfony 4.0 apps, but symfony 4.0 isn't maintained so... I think you should adapt your config on the maintained version of symfony
As you want :)
|
Can you also update CHANGELOG? Run |
This was referenced Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On SF 4.1+, the .env file is versionned, only the .env.local is not versionned anymore