feat: pull all bake targets by default #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only a single named bake target would be pulled. This was awkward as one would need to know all targets and then loop. Now, depot pull will download all targets simultaneously by default. The names of the targets should correspond to those used by docker compose and therefore one should be able to immediately run `docker compose up`. The `--target` option for depot pull has been changed to accept more than one string and now acts like a filter for the bake images to download. Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Signed-off-by: Chris Goller <goller@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only a single named bake target would be pulled. This was awkward as one would need to know all targets and then loop.
Now, depot pull will download all targets simultaneously by default.
The names of the targets should correspond to those used by docker compose and therefore one should be able to immediately run
docker compose up.The
--targetoption for depot pull has been changed to accept more than one string and now acts like a filter for the bake images to download.