Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement check for groupby slicing and aggregation patterns. #54

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Implement check for groupby slicing and aggregation patterns. #54

wants to merge 5 commits into from

Commits on Mar 8, 2019

  1. Failing implementation for 'groupby' aggregations.

    @simchuck
    simchuck committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    843174b View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Fix check for groupby() aggregations. 

    Add check to distinguish method vs. function.

Also, due to structure of AST, need to treat chained aggregation method
separately from sliced method, i.e.,

    df.groupby()[]          # visitor node is ast.Subscript
    df.groupby()[].agg()    # visitor node is ast.Call
    @simchuck
    simchuck committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    3c5dd41 View commit details
    Browse the repository at this point in the history

  2. Fix Flake8 formatting.

    @simchuck
    simchuck committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    a2d538c View commit details
    Browse the repository at this point in the history

  3. Fix merge conflict.

    @simchuck
    simchuck committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    b8a1288 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Add tests for slicing on non- groupby methods.

    @simchuck
    simchuck committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    fa8777b View commit details
    Browse the repository at this point in the history