[PHPStanRules] Remove ForbiddenNestedForeachWithEmptyStatementRule, a…

…s not very helpful in pratise (#3945)
deprecated-packages · Feb 20, 2022 · 9f70dfd · 9f70dfd
1 parent 802cb62
commit 9f70dfd
Show file tree

Hide file tree

Showing 11 changed files with 2 additions and 282 deletions.
diff --git a/packages/phpstan-rules/config/static-rules.neon b/packages/phpstan-rules/config/static-rules.neon
@@ -132,10 +132,6 @@ services:
         class: Symplify\PHPStanRules\Rules\RequireThisCallOnLocalMethodRule
         tags: [phpstan.rules.rule]
 
-    -
-        class: Symplify\PHPStanRules\Rules\ForbiddenNestedForeachWithEmptyStatementRule
-        tags: [phpstan.rules.rule]
-
     -
         class: Symplify\PHPStanRules\Rules\ForbiddenMultipleClassLikeInOneFileRule
         tags: [phpstan.rules.rule]

diff --git a/packages/phpstan-rules/docs/rules_overview.md b/packages/phpstan-rules/docs/rules_overview.md
@@ -1304,38 +1304,6 @@ final class SomeClass extends TestCase
 
 <br>
 
-## ForbiddenNestedForeachWithEmptyStatementRule
-
-Nested foreach with empty statement is not allowed
-
-- class: [`Symplify\PHPStanRules\Rules\ForbiddenNestedForeachWithEmptyStatementRule`](../src/Rules/ForbiddenNestedForeachWithEmptyStatementRule.php)
-
-```php
-$collectedFileErrors = [];
-
-foreach ($errors as $fileErrors) {
-    foreach ($fileErrors as $fileError) {
-        $collectedFileErrors[] = $fileError;
-    }
-}
-```
-
-:x:
-
-<br>
-
-```php
-$collectedFileErrors = [];
-
-foreach ($fileErrors as $fileError) {
-    $collectedFileErrors[] = $fileError;
-}
-```
-
-:+1:
-
-<br>
-
 ## ForbiddenNodeRule
 
 "%s" is forbidden to use

diff --git a/packages/phpstan-rules/src/Rules/ForbiddenNestedForeachWithEmptyStatementRule.php b/packages/phpstan-rules/src/Rules/ForbiddenNestedForeachWithEmptyStatementRule.php
diff --git a/.../ForbiddenNestedForeachWithEmptyStatementRule/Fixture/NestedForeachWithEmptyStatement.php b/.../ForbiddenNestedForeachWithEmptyStatementRule/Fixture/NestedForeachWithEmptyStatement.php
diff --git a/...stan-rules/tests/Rules/ForbiddenNestedForeachWithEmptyStatementRule/Fixture/SkipArray.php b/...stan-rules/tests/Rules/ForbiddenNestedForeachWithEmptyStatementRule/Fixture/SkipArray.php
diff --git a/...ptyStatementRule/Fixture/SkipNestedForeachWithEmptyStatementWithDifferentVariableLoop.php b/...ptyStatementRule/Fixture/SkipNestedForeachWithEmptyStatementWithDifferentVariableLoop.php
diff --git a/...denNestedForeachWithEmptyStatementRule/Fixture/SkipNestedForeachWithNonEmptyStatement.php b/...denNestedForeachWithEmptyStatementRule/Fixture/SkipNestedForeachWithNonEmptyStatement.php
diff --git a/...tests/Rules/ForbiddenNestedForeachWithEmptyStatementRule/Fixture/SkipNotNestedForeach.php b/...tests/Rules/ForbiddenNestedForeachWithEmptyStatementRule/Fixture/SkipNotNestedForeach.php
diff --git a/...nNestedForeachWithEmptyStatementRule/ForbiddenNestedForeachWithEmptyStatementRuleTest.php b/...nNestedForeachWithEmptyStatementRule/ForbiddenNestedForeachWithEmptyStatementRuleTest.php
diff --git a/...ules/tests/Rules/ForbiddenNestedForeachWithEmptyStatementRule/config/configured_rule.neon b/...ules/tests/Rules/ForbiddenNestedForeachWithEmptyStatementRule/config/configured_rule.neon
diff --git a/phpstan.neon b/phpstan.neon
@@ -354,6 +354,8 @@ parameters:
         # known types
         - '#Method Symplify\\Astral\\NodeFinder\\SimpleNodeFinder\:\:findByType\(\) should return array<T of PhpParser\\Node\> but returns array<PhpParser\\Node\>#'
         - '#Method Symplify\\Astral\\NodeFinder\\SimpleNodeFinder\:\:findFirstParentByType\(\) should return T of PhpParser\\Node\|null but returns class\-string<T of PhpParser\\Node\>\|T of PhpParser\\Node#'
+         # node finder generics meshup
+        - '#Method Symplify\\Astral\\NodeFinder\\SimpleNodeFinder\:\:findFirstByType\(\) should return T of PhpParser\\Node\|null but returns PhpParser\\Node\|null#'
 
         -
             message: '#Use void instead of modify and return self object#'
@@ -391,11 +393,6 @@ parameters:
             message: '#Removing parent param type is forbidden#'
             path: *FileLoader.php
 
-        # this class is used by scoper, so better use less external deps
-        -
-            message: '#Nested foreach with empty statement is not allowed#'
-            path: packages/php-config-printer/src/PhpParser/NodeFactory/ConfiguratorClosureNodeFactory.php
-
         - '#Method "processTokensByFixer\(\)" returns bool type, so the name should start with is/has/was#'
 
         -
@@ -523,7 +520,6 @@ parameters:
 
         # parallel
         - '#popen(.*?)" is forbidden to use#'
-        - '#PHPDoc tag @param for parameter \$postFileCallback with type \(Closure\)\|null is not subtype of native type Closure#'
 
         # json return
         -
@@ -567,9 +563,6 @@ parameters:
                  - packages/symfony-static-dumper/src/Routing/RoutesProvider.php
                  - packages/autowire-array-parameter/src/DependencyInjection/DefinitionFinder.php
 
-         # node finder generics meshup
-        - '#Method Symplify\\Astral\\NodeFinder\\SimpleNodeFinder\:\:findFirstByType\(\) should return T of PhpParser\\Node\|null but returns PhpParser\\Node\|null#'
-
         # false positive, due to scoped autoload of rector.php
         - '#Call to an undefined method Symfony\\Component\\DependencyInjection\\Loader\\Configurator\\ServiceConfigurator\:\:configure\(\)#'