Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

[PHPStanRules] Remove CheckTraitMethodOnlyDelegateOtherClassRule, not much value #2927

Merged
merged 2 commits into from
Feb 9, 2021
Merged

[PHPStanRules] Remove CheckTraitMethodOnlyDelegateOtherClassRule, not much value #2927

merged 2 commits into from
Feb 9, 2021

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Feb 9, 2021 •
edited
Loading

This rule didn't proove as much useful in practical coding.

Better use Symplify\PHPStanRules\Rules\ForbiddenNodeRule with Trait_:

services:
    -
        class: Symplify\PHPStanRules\Rules\ForbiddenNodeRule
        tags: [phpstan.rules.rule]
        arguments:
            forbiddenNodes:
                 - PhpParser\Node\Stmt\Trait_

@TomasVotruba TomasVotruba enabled auto-merge (squash) February 9, 2021 10:59
@TomasVotruba TomasVotruba merged commit 86bd631 into master Feb 9, 2021
@TomasVotruba TomasVotruba deleted the phpstan-rules-trait-magic branch February 9, 2021 11:04
@deprecated-packages deprecated-packages locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TomasVotruba