This repository has been archived by the owner on Dec 3, 2023. It is now read-only.
[Cleaning] Get rid of nullable parameters #2977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-non-nullable
branch
from
452b571 to
e472c65
Compare
TomasVotruba
force-pushed
the
tv-non-nullable
branch
9 times, most recently
from
7a7ff29 to
6381098
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-non-nullable
branch
2 times, most recently
from
ebe5537 to
ec4dd3b
Compare
TomasVotruba
force-pushed
the
tv-non-nullable
branch
2 times, most recently
from
7c4a231 to
4df2d02
Compare
TomasVotruba
force-pushed
the
tv-non-nullable
branch
from
4df2d02 to
e4038e9
Compare
TomasVotruba
force-pushed
the
tv-non-nullable
branch
3 times, most recently
from
27e834b to
19fa149
Compare
TomasVotruba
force-pushed
the
tv-non-nullable
branch
from
19fa149 to
402cd7a
Compare
staabm
reviewed
Mar 26, 2021
| if ($baseBranch !== null) { | ||
| $url .= '&base=' . $baseBranch; | ||
| } | ||
| $url .= '&base=' . $baseBranch; |
There was a problem hiding this comment.
should the branch name be escaped for use in a url?
There was a problem hiding this comment.
It might be, but Changelog Linker is now deprecated, see: #3027
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @afilina and https://afilina.com/null-hell