fix: 타임라인 커서 기준 memoryPK -> recordAt로 변경 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results24 tests 24 ✅ 1s ⏱️ Results for commit 41a30ff. ♻️ This comment has been updated with latest results. |
its-sky
requested changes
Jul 25, 2024
|
|
||
| @Getter | ||
| @NoArgsConstructor | ||
| public class Timeline<T extends Memory> { |
There was a problem hiding this comment.
다시 생각해보니 굳이 제네릭으로 구현할 필요가 없네요 수정했습니다.
| Slice<Memory> findPrevMemoryByMemberId( | ||
| Long memberId, Long cursorId, Pageable pageable, LocalDate recordAt); | ||
| Timeline<Memory> findPrevMemoryByMemberId( | ||
| Long memberId, LocalDate cursorRecordAt, LocalDate recordAt); |
There was a problem hiding this comment.
프론트엔드에서 마지막 기록의 날짜를 넘겨주면 되는건데 id로 조회하고 해당 기록의 날짜를 뽑아서 굳이 넘기는 이유가 있나요?
There was a problem hiding this comment.
프론트에게 혼란을 줄 수 있을거 같아서 파라미터를 그래도 사용하려 했는데 그냥 한 번 더 이야기 하면 될 문제네요 수정 했습니다.
| @@ -47,7 +47,7 @@ public ApiResponse<MemoryResponse> update( | |||
|
|
|||
| @GetMapping("/timeline") | |||
| public ApiResponse<?> timeline( | |||
| @LoginMember Long memberId, @ModelAttribute TimelineRequestDto timelineRequestDto) { | |||
| @LoginMember Long memberId, TimelineRequestDto timelineRequestDto) { | |||
There was a problem hiding this comment.
확인 결과 ModelAttribute 없이도 동작하여 삭제하였습니다.
| @@ -47,7 +47,7 @@ public ApiResponse<MemoryResponse> update( | |||
|
|
|||
| @GetMapping("/timeline") | |||
| public ApiResponse<?> timeline( | |||
| @LoginMember Long memberId, @ModelAttribute TimelineRequestDto timelineRequestDto) { | |||
| @LoginMember Long memberId, TimelineRequestDto timelineRequestDto) { | |||
| memoryRepository | ||
| .findById(timeline.getCursorId()) | ||
| .orElseThrow(() -> new NotFoundException(MemoryErrorType.NOT_FOUND)); | ||
| cursorRecordAt = memory.getRecordAt(); |
There was a problem hiding this comment.
왜 굳이 id로 넘겨서 recordAt을 조회하는 쿼리 한번을 써야 할까요? 그냥 프론트엔드에서 recordAt 데이터를 넘기면 될거 같다고 생각합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
📝 참고사항
처음 최신순 조회 결과
cursorId를 파라미터로 추가한 후, 조회
