fix: jwt 오류 해결 및 컨플릭트 해결 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
네이버 컨벤션 전체 적용
네이버 컨벤션 전체 적용
its-sky
approved these changes
Jul 6, 2024
| httpHeaders.add(REFRESH_HEADER.getValue(), jwtTokenResponseDto.refreshToken()); | ||
| httpHeaders.add(ACCESS_HEADER.getValue(), jwtTokenResponseDto.accessToken()); | ||
|
|
||
| return ResponseEntity.ok(jwtTokenResponseDto); |
There was a problem hiding this comment.
이거 ApiResponse.success(MemberSuccessType.~, jwtTokenResponseDto);로 하면 좋을거 같아요~
| public ResponseEntity<?> signUp(@RequestBody MemberCreateDto memberCreate) { | ||
| authService.signUp(memberCreate); | ||
|
|
||
| return ResponseEntity.ok().build(); |
There was a problem hiding this comment.
signUp response body가 없으면 ResponseEntity.noContent().build(); 로 처리하면 좋을거 같습니다~
| return Arrays.stream(clazz.getEnumConstants()) | ||
| .filter(e -> e.getValue().equals(dbData)) | ||
| .findFirst() | ||
| .orElseThrow(() -> new IllegalArgumentException("Unknown code: " + dbData)); |
There was a problem hiding this comment.
요거 저희 공통 Exception으로 바꾸면 좋을거 같아요~
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
📝 참고사항
📚 기타