Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: memoryrepository findbyid 메서드 추가 및 S3 Region 설정 추가 #41

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix: memoryrepository findbyid 메서드 추가 및 S3 Region 설정 추가 #41

merged 2 commits into from
Jul 15, 2024

Conversation

ywonchae1
Copy link
Member

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • ImageUpdateServiceImpl에서 사용하는 MemoryRepository findById를 구현하였습니다.
  • S3 Region 설정을 추가하였습니다.

@ywonchae1 ywonchae1 self-assigned this Jul 15, 2024
@ywonchae1 ywonchae1 linked an issue Jul 15, 2024 that may be closed by this pull request
🐛 MemoryRepository findById 구현 #40
Closed
its-sky
its-sky approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@its-sky its-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

당신 멋져

@ywonchae1 ywonchae1 merged commit 28b4e2a into develop Jul 15, 2024
1 check passed
@ywonchae1 ywonchae1 deleted the fix/40-memoryrepository-findbyid branch July 15, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penrose15 penrose15 penrose15 left review comments

@its-sky its-sky its-sky approved these changes

Assignees

@ywonchae1 ywonchae1

Labels
🚨🚨emergency🚨🚨 fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 MemoryRepository findById 구현
3 participants
@ywonchae1 @its-sky @penrose15