Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: s3 url 조회시 파일이 깨지는 문제 해결 #43

Merged
merged 10 commits into from
Jul 16, 2024
Merged

fix: s3 url 조회시 파일이 깨지는 문제 해결 #43

merged 10 commits into from
Jul 16, 2024

Conversation

penrose15
Copy link
Collaborator

@penrose15 penrose15 commented Jul 15, 2024 •
edited
Loading

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 파일 업로드 이후 s3 url 조회시 이미지가 깨져서 보이지 않는 문제 발생
  • 파일의 기존 이름 -> UUID 변경 시 뒤에 파일 확장명을 붙이지 않아 발생한 문제
    • 파일 이름 UUID 변환 후, .파일 확장명 추가로 해결
  • s3 조회 url cloudFront 도메인으로 변경

@penrose15 penrose15 added the fix label Jul 15, 2024
@penrose15 penrose15 self-assigned this Jul 15, 2024
ywonchae1
ywonchae1 reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@ywonchae1 ywonchae1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 !!

module-presentation/src/main/java/com/depromeet/image/api/ImageController.java Outdated Show resolved Hide resolved
module-presentation/src/main/java/com/depromeet/security/filter/JwtAuthenticationFilter.java Outdated Show resolved Hide resolved
its-sky
its-sky reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@its-sky its-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드리뷰 확인 부탁드려요

module-domain/src/test/java/com/depromeet/TestConfiguration.java Outdated Show resolved Hide resolved
...tence-database/src/main/java/com/depromeet/memory/repository/MemoryDetailRepositoryImpl.java Outdated Show resolved Hide resolved
module-presentation/src/main/java/com/depromeet/memory/MemoryTempController.java Outdated Show resolved Hide resolved
module-presentation/src/main/java/com/depromeet/security/filter/JwtAuthenticationFilter.java Outdated Show resolved Hide resolved
module-independent/src/main/java/com/depromeet/util/ImageNameUtil.java Outdated Show resolved Hide resolved
module-presentation/src/main/java/com/depromeet/image/api/ImageController.java Outdated Show resolved Hide resolved
module-presentation/src/main/java/com/depromeet/image/api/ImageController.java Show resolved Hide resolved
module-presentation/src/main/java/com/depromeet/image/api/ImageController.java Outdated Show resolved Hide resolved
module-presentation/src/main/java/com/depromeet/image/api/ImageController.java Show resolved Hide resolved
module-presentation/src/main/java/com/depromeet/image/service/ImageUploadServiceImpl.java Show resolved Hide resolved
@penrose15 penrose15 requested a review from kdomo July 15, 2024 14:37
@penrose15 penrose15 merged commit a6dc16a into develop Jul 16, 2024
@its-sky its-sky deleted the fix/42-s3-url branch July 30, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywonchae1 ywonchae1 ywonchae1 left review comments

@its-sky its-sky its-sky approved these changes

@kdomo kdomo Awaiting requested review from kdomo

Assignees

@penrose15 penrose15

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ cloudfront 추가 🐛 image url 조회 시 이미지 파일이 깨져 보이지 않는 버그 수정
3 participants
@penrose15 @its-sky @ywonchae1