Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public actions to not checkout code #146

Open
straker opened this issue Mar 21, 2024 · 0 comments
Open

Update public actions to not checkout code #146

straker opened this issue Mar 21, 2024 · 0 comments

Comments

@straker
Copy link
Contributor

straker commented Mar 21, 2024

We've determined that for repos using yarn workspace or repos needing private NPM auth credentials that running the @actions/checkout step will override any prior setup. We added a parameter to the create-update-axe-core-pull-request action to conditionally run the checkout step to handle this. However this solution isn't ideal and we should instead just not check out at all in the public actions. Instead the calling code of the public action should be responsible for checking out the repo and doing setup before calling the action.

In order to do this in piecemeal (so we don't break all the actions) we should:

  1. Add the conditional parameter to every public action that uses the @actions/checkout step
  2. After that, each repo that uses the public action should update their actions to do the checkout / setup step and use the conditional parameter to disable the step in the public action
  3. Once all repos have been converted to this new style we can delete the conditional parameter from the public actions
  4. Lastly we can remove the usage of the conditional parameter in all our other repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant