Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(.github/action): add deploy-release github action #157

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

maksym-shynkarenko
Copy link
Contributor

@maksym-shynkarenko maksym-shynkarenko commented Apr 11, 2024

Added the GitHub action deploy-release to label all related issues with the package version and create a PR to sync branches.

Closes: #90

@maksym-shynkarenko maksym-shynkarenko requested a review from a team as a code owner April 11, 2024 15:03
Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things inline -

@@ -0,0 +1,43 @@
# deploy-release-v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name is a bit misleading, we aren't deploying anything here. We're moving released issues and creating a sync PR, maybe:

Suggested change
# deploy-release-v1
# move-released-issues-and-create-sync-pr-v1

Thoughts @maksym-shynkarenko @straker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. This name was from the task so I thought it was confirmed. Will rename it

Comment on lines 27 to 30
- uses: actions/checkout@v4
with:
# Fetch all history
fetch-depth: 0
Copy link
Contributor

@Zidious Zidious Apr 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a note here not to note remove this when #146 gets picked up as this is should be affected

| `project-number` | No | A project number of the project board | 66 |
| `head` | No | A head branch to sync from | main |
| `base` | No | A target branch for the created pull request | develop |
| `pr-team-reviewers` | No | Reviewers to tag on the created pull request | NA |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a default for pr-team-reviewers to be axe-api-team

…-issues-and-create-sync-pr. Add a default value of the input pr-team-reviewers
@maksym-shynkarenko maksym-shynkarenko dismissed Zidious’s stale review April 15, 2024 14:06

changed according to the review

- uses: dequelabs/axe-api-team-public/.github/actions/generate-commit-list-v1@main
id: get-commit-list
with:
tag: v${{ steps.get-package-version.outputs.version }}
Copy link
Contributor

@straker straker Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be the tag prior to the current one. If v4.9.0 is released we need the tag to be the prior one (e.g. v4.8.4) in order to get the list of commits from the last release to the current HEAD. Otherwise the current tag on main/master is the current HEAD and the commit list will be empty.

@maksym-shynkarenko maksym-shynkarenko dismissed straker’s stale review April 16, 2024 13:07

changed according to the review

Comment on lines 28 to 32
# This step is required for the next steps
- uses: actions/checkout@v4
with:
# Fetch all history
fetch-depth: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you forgot to address #157 (comment). We should remove the checkout step completely instead of adding a new input to disable the checkout. The new input described in #146 was for previously created actions that needed to convert over without breaking our workflows.

@maksym-shynkarenko maksym-shynkarenko dismissed straker’s stale review April 17, 2024 14:57

changed according to the review

@maksym-shynkarenko maksym-shynkarenko merged commit 2fb4a2a into main Apr 17, 2024
15 checks passed
@maksym-shynkarenko maksym-shynkarenko deleted the ci-add-deploy-release branch April 17, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create deploy-release public action
3 participants