-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(.github/action): add deploy-release github action #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things inline -
@@ -0,0 +1,43 @@ | |||
# deploy-release-v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the name is a bit misleading, we aren't deploying anything here. We're moving released issues and creating a sync PR, maybe:
# deploy-release-v1 | |
# move-released-issues-and-create-sync-pr-v1 |
Thoughts @maksym-shynkarenko @straker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. This name was from the task so I thought it was confirmed. Will rename it
- uses: actions/checkout@v4 | ||
with: | ||
# Fetch all history | ||
fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a note here not to note remove this when #146 gets picked up as this is should be affected
| `project-number` | No | A project number of the project board | 66 | | ||
| `head` | No | A head branch to sync from | main | | ||
| `base` | No | A target branch for the created pull request | develop | | ||
| `pr-team-reviewers` | No | Reviewers to tag on the created pull request | NA | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a default for pr-team-reviewers
to be axe-api-team
…-issues-and-create-sync-pr. Add a default value of the input pr-team-reviewers
changed according to the review
- uses: dequelabs/axe-api-team-public/.github/actions/generate-commit-list-v1@main | ||
id: get-commit-list | ||
with: | ||
tag: v${{ steps.get-package-version.outputs.version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be the tag prior to the current one. If v4.9.0 is released we need the tag to be the prior one (e.g. v4.8.4) in order to get the list of commits from the last release to the current HEAD
. Otherwise the current tag on main/master is the current HEAD
and the commit list will be empty.
…eleased-issues-and-create-sync-pr action
changed according to the review
# This step is required for the next steps | ||
- uses: actions/checkout@v4 | ||
with: | ||
# Fetch all history | ||
fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you forgot to address #157 (comment). We should remove the checkout step completely instead of adding a new input to disable the checkout. The new input described in #146 was for previously created actions that needed to convert over without breaking our workflows.
…and-create-sync-pr action
…create-sync-pr action
changed according to the review
Added the GitHub action
deploy-release
to label all related issues with the package version and create a PR to sync branches.Closes: #90