Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frame-tested for unloaded iframes #323

Closed
straker opened this issue Jun 20, 2023 · 3 comments
Closed

Add frame-tested for unloaded iframes #323

straker opened this issue Jun 20, 2023 · 3 comments
Assignees
Labels
playwright playwright integration QA SIGNOFF: passed This ticket has passed QA selenium Selenium integration tech debt

Comments

@straker
Copy link
Contributor

straker commented Jun 20, 2023

The change was made to our javascript APIs but needs to be ported to here.

@Zidious Zidious added selenium Selenium integration playwright playwright integration labels Jun 20, 2023
@AdnoC AdnoC closed this as completed in 66ff5bd Oct 5, 2023
@padmavemulapati
Copy link

padmavemulapati commented Oct 6, 2023

@AdnoC , Is this ticket QA-Required? If yes please add few QA-Notes

@padmavemulapati
Copy link

padmavemulapati commented Oct 17, 2023

Verified with the latest axe-core-maven-html_4.8.0` version ,
created a test file for unloaded iframes(lazy loaded iframes)

  1. axe-core-maven-html_playwright is working fine with the lazy loaded iframes it is not hanging and giving frame-title violations.
    Note: As per @AdnoC, other than selenium packages, we can see a frame-title violationonly not aframe-tested` incomplete result, as this lazy loaded iframes fix is done for selenium.

Test script:

 @Test
    public void scanPageAndSaveResultsToJsonFileTest() throws IOException {
        String reportName = "iframesTest.json";
        page.navigate("http://localhost:8081/iframesfixture.html");
        AxeBuilder axeBuilder = new AxeBuilder(page);
        AxeResults axeResults = axeBuilder.analyze();
        Reporter reporter = new Reporter().JSONStringify(axeResults, reportName);
        int actualViolationsCount = getViolationsCount(reportName);
        Assert.assertEquals(1, actualViolationsCount);
    }

Image

  1. axe-core-maven-html_selenium is working fine with the lazy loaded iframes it is not hanging and giving frame-title violations and frame-tested incomplete results

TestScript:

@Test
    public void scanPageAndSaveResultsToJsonFileTest() throws IOException, OperationNotSupportedException {
        String reportName = "iframesTest";
        this.webDriver.get("http://localhost:8081/iframesfixture.html");
        Results result = new AxeBuilder().analyze(webDriver);
        AxeReporter.writeResultsToJsonFile("src/test/java/results/"+reportName, result);
        int actualViolationsCount = getViolationsCount(reportName);
        Assert.assertEquals(1, actualViolationsCount);
    }

Image

Environment:

Label Value
Product axe-core-maven-html
Version 4.8.0
OS-Details _MAC- Intel Core i7 - 11.6.8 & Windows11 _
BrowserDetails Chrome Version 118.0.5993.70 (Official Build) (64-bit) & Firefox 118.0.1

@padmavemulapati
Copy link

Verified with the latest axe-core-maven-html_Playwright - 4.8.1-SNAPSHOT/playwright-4.8.1-20240109.201525-1
created a test file for unloaded iframes(lazy loaded iframes)

  1. axe-core-maven-html_playwright is working fine with the lazy loaded iframes it is not hanging and giving frame-title violations.
    Note: Here As per changes other than selenium packages, we can see a frame-title violationonly not aframe-tested` incomplete result, as this lazy loaded iframes fix is done for selenium.

Test script:

 @Test
    public void scanPageAndSaveResultsToJsonFileTest() throws IOException {
        String reportName = "iframesTest.json";
        page.navigate("http://localhost:8081/iframesfixture.html");
        AxeBuilder axeBuilder = new AxeBuilder(page);
        AxeResults axeResults = axeBuilder.analyze();
        Reporter reporter = new Reporter().JSONStringify(axeResults, reportName);
        int actualViolationsCount = getViolationsCount(reportName);
        Assert.assertEquals(1, actualViolationsCount);
    }
image
  1. axe-core-maven-html_selenium is working fine with the lazy loaded iframes it is not hanging and giving frame-title violations and frame-tested incomplete results

TestScript:

@Test
    public void scanPageAndSaveResultsToJsonFileTest() throws IOException, OperationNotSupportedException {
        String reportName = "iframesTest";
        this.webDriver.get("http://localhost:8081/iframesfixture.html");
        Results result = new AxeBuilder().analyze(webDriver);
        AxeReporter.writeResultsToJsonFile("src/test/java/results/"+reportName, result);
        int actualViolationsCount = getViolationsCount(reportName);
        Assert.assertEquals(1, actualViolationsCount);
    }
image

Environment:

Label Value
Product axe-core-maven-html
Version _ 4.8.1-SNAPSHOT/4.8.1-20240109.201525-1_
OS-Details _MAC- Intel Core i7 - 11.6.8 & Windows11 _
BrowserDetails Chrome Version 120.0.6099.129 (Official Build) (64-bit) & Firefox 121.1

@padmavemulapati padmavemulapati added the QA SIGNOFF: passed This ticket has passed QA label Jan 11, 2024
michael-siek pushed a commit that referenced this issue Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playwright playwright integration QA SIGNOFF: passed This ticket has passed QA selenium Selenium integration tech debt
Projects
None yet
Development

No branches or pull requests

4 participants