Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: work with extremely large results #304

Merged
merged 13 commits into from
Mar 23, 2023
Merged

fix: work with extremely large results #304

merged 13 commits into from
Mar 23, 2023

Conversation

AdnoC
Copy link
Contributor

@AdnoC AdnoC commented Mar 20, 2023

@AdnoC AdnoC requested a review from a team as a code owner March 20, 2023 12:37
Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things inline otherwise LGTM

} catch (Exception e) {
throw new RuntimeException(e);
}
int sizeLimit = 15_000_000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be consistent with the sizeLimit we've set with the integrations core-npm has it set at 60_000_000

Suggested change
int sizeLimit = 15_000_000;
int sizeLimit = 60_000_000;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hadn't realized this was changed from the initial PR. Will adjust in all my PRs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

60 million is too large. Breaks webdriver

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least in ruby

@@ -474,13 +472,38 @@ private Object finishRun(ArrayList<Object> partialResults) {
Page blankPage = browser.newPage();
blankPage.evaluate(getAxeScript() + getAxeConfigure(hasRunPartial));

String partialResString = "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit -

This function is already quite large, breaking it out into its own function would allow commenting on what and why it was needed and can reference proposal

} catch (Exception e) {
throw new RuntimeException(e);
}
int sizeLimit = 15_000_000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be consistent with the sizeLimit we've set with the integrations core-npm has it set at 60_000_000

Suggested change
int sizeLimit = 15_000_000;
int sizeLimit = 60_000_000;

@@ -739,10 +744,25 @@ private Results analyzePost43x(final WebDriver webDriver, final Object rawContex

String prevWindow = WebDriverExtensions.openAboutBlank(webDriver);
injectAxe(webDriver);
String partialResString = "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit -

This function is already quite large, breaking it out into its own function would allow commenting on what and why it was needed and can reference proposal

@AdnoC AdnoC force-pushed the fix-large-tests branch from 81439fb to 697c930 Compare March 22, 2023 15:36
@AdnoC AdnoC dismissed Zidious’s stale review March 22, 2023 15:45

Tried to make requested changes. Unfortunately 60mil is too much for CI's memory environment

Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants