chore: update jacoco dep #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
previously approved these changes
Jun 16, 2023
|
Tried to do the same for Selenium but ran into issues with the server needing python, so installed http-server there and then needed to port over @dbjorge fix of adding the - |
|
Also noticed that Selenium isn't using jacoco, so don't now if we have code coverage running there. |
stephenmathieson
approved these changes
Jun 16, 2023
Ya that is correct - Selenium doesn't have any code coverage checks like Jacoco ATM |
This was referenced Jul 26, 2023
This was referenced Aug 24, 2023
michael-siek
pushed a commit
that referenced
this pull request
Sep 28, 2023
* chore: update jacoco dep * fix http-server
michael-siek
pushed a commit
that referenced
this pull request
Feb 7, 2024
* chore: update jacoco dep * fix http-server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to run the Playwright package but it errored on jacoco. Updating the dependency to support openjdk 20. Also made the http-server log silent.