Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove broken CircleCI badge #396

Merged
merged 2 commits into from
Nov 20, 2023
Merged

docs: remove broken CircleCI badge #396

merged 2 commits into from
Nov 20, 2023

Conversation

Zidious
Copy link
Contributor

@Zidious Zidious commented Nov 18, 2023

This is always broke. Removing it.

image

No QA Required.

@Zidious Zidious requested a review from a team as a code owner November 18, 2023 06:28
michael-siek
michael-siek approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@michael-siek michael-siek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with removing this but we should move our deploy workflow from CircleCI to GHA since it looks like that's the only thing we use CircleCI for

@Zidious
Copy link
Contributor Author

Zidious commented Nov 20, 2023

I'm ok with removing this but we should move our deploy workflow from CircleCI to GHA since it looks like that's the only thing we use CircleCI for

#397

@Zidious Zidious requested a review from michael-siek November 20, 2023 00:25
@Zidious Zidious merged commit 3b49420 into develop Nov 20, 2023
8 checks passed
@Zidious Zidious deleted the docs-remove-circleci-badge branch November 20, 2023 22:18
michael-siek pushed a commit that referenced this pull request Feb 7, 2024
@Zidious @michael-siek
docs: remove broken CircleCI badge (#396)
6c274a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-siek michael-siek Awaiting requested review from michael-siek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zidious @michael-siek