Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix eslint errors and warnings #1079

Merged
merged 2 commits into from
Jun 4, 2024
Merged

chore: fix eslint errors and warnings #1079

merged 2 commits into from
Jun 4, 2024

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 4, 2024 •
edited
Loading

Fixes all the lint errors and warnings in preparation for #1078

No QA needed

@straker straker requested a review from a team as a code owner June 4, 2024 13:56
straker
straker commented Jun 4, 2024
View reviewed changes
eslint.config.js
@@ -33,7 +33,8 @@ module.exports = [
'@typescript-eslint/ban-types': 'off',
'@typescript-eslint/no-unused-vars': 'error',
'@typescript-eslint/no-explicit-any': 'error',
'@typescript-eslint/no-non-null-assertion': 'error'
'@typescript-eslint/no-non-null-assertion': 'error',
'@typescript-eslint/no-require-imports': 'off'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use imports or requires based on the file (test files, examples, eslint config itself, postinstall, etc.). Instead of having to disable it or ignore it for every file we want, easier to just disable the rule and let us decide when to use require or import per file.

@straker straker merged commit 2c713b5 into develop Jun 4, 2024
33 of 34 checks passed
@straker straker deleted the eslint-errors branch June 4, 2024 14:09
github-merge-queue bot pushed a commit to camunda/camunda that referenced this pull request Aug 19, 2024
@renovate
deps: Update dependency @axe-core/playwright to v4.10.0 (main) (#21343)
43d6187 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@axe-core/playwright](https://github.com/dequelabs/axe-core-npm) |
[`4.9.1` ->
`4.10.0`](https://renovatebot.com/diffs/npm/@axe-core%2fplaywright/4.9.1/4.10.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@axe-core%2fplaywright/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@axe-core%2fplaywright/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@axe-core%2fplaywright/4.9.1/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@axe-core%2fplaywright/4.9.1/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>dequelabs/axe-core-npm (@&#8203;axe-core/playwright)</summary>

###
[`v4.10.0`](https://github.com/dequelabs/axe-core-npm/releases/tag/v4.10.0):
Release 4.10.0

[Compare
Source](https://github.com/dequelabs/axe-core-npm/compare/v4.9.1...v4.10.0)

#### What's Changed

- fix(playwright): Add missing await on page.evaluate by
[@&#8203;KuSh](https://github.com/KuSh) in
[dequelabs/axe-core-npm#1063
- chore: update to support eslint 9 flat config by
[@&#8203;michael-siek](https://github.com/michael-siek) in
[dequelabs/axe-core-npm#1064
- chore: merge master into develop by
[@&#8203;attest-team-ci](https://github.com/attest-team-ci) in
[dequelabs/axe-core-npm#1071
- chore: bump puppeteer from 21.7.0 to 22.10.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1073
- chore: bump sinon from 17.0.1 to 18.0.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1076
- chore: bump chromedriver from 121.0.0 to 125.0.3 by
[@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1075
- chore: fix eslint errors and warnings by
[@&#8203;straker](https://github.com/straker) in
[dequelabs/axe-core-npm#1079
- chore: bump typescript-eslint from 8.0.0-alpha.12 to 8.0.0-alpha.26 by
[@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1078
- chore: bump the npm-low-risk group across 1 directory with 22 updates
by [@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1077
- chore: use updated browser-driver-manager by
[@&#8203;scottmries](https://github.com/scottmries) in
[dequelabs/axe-core-npm#1080
- chore: bump the npm-low-risk group with 27 updates by
[@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1081
- chore: bump chromedriver from 125.0.3 to 126.0.4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1082
- feat: Update axe-core to v4.10.0 by
[@&#8203;attest-team-ci](https://github.com/attest-team-ci) in
[dequelabs/axe-core-npm#1088
- chore: downgrade lerna to resolve ESM requirement by
[@&#8203;michael-siek](https://github.com/michael-siek) in
[dequelabs/axe-core-npm#1098
- fix(cli): include `dotenv` dep by
[@&#8203;michael-siek](https://github.com/michael-siek) in
[dequelabs/axe-core-npm#1103
- chore: RC v4.10.0 by
[@&#8203;github-actions](https://github.com/github-actions) in
[dequelabs/axe-core-npm#1108
- Release 4.10.0 by [@&#8203;dequejenn](https://github.com/dequejenn)
in
[dequelabs/axe-core-npm#1110

#### New Contributors

- [@&#8203;KuSh](https://github.com/KuSh) made their first
contribution in
[dequelabs/axe-core-npm#1063

**Full Changelog**:
dequelabs/axe-core-npm@v4.9.1...v4.10.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/camunda/camunda).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIl19-->
github-merge-queue bot pushed a commit to ionic-team/ionic-framework that referenced this pull request Aug 30, 2024
@renovate
chore(deps): update playwright (#29818)
61a97f2 
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | Type |
Update |
|---|---|---|---|---|---|---|---|
| [@axe-core/playwright](https://github.com/dequelabs/axe-core-npm) |
[`^4.9.1` ->
`^4.10.0`](https://renovatebot.com/diffs/npm/@axe-core%2fplaywright/4.9.1/4.10.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@axe-core%2fplaywright/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@axe-core%2fplaywright/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@axe-core%2fplaywright/4.9.1/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@axe-core%2fplaywright/4.9.1/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | minor |
| [@playwright/test](https://playwright.dev)
([source](https://github.com/microsoft/playwright)) | [`^1.46.0` ->
`^1.46.1`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.46.0/1.46.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@playwright%2ftest/1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@playwright%2ftest/1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@playwright%2ftest/1.46.0/1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@playwright%2ftest/1.46.0/1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch |
| mcr.microsoft.com/playwright | `v1.46.0` -> `v1.46.1` |
[![age](https://developer.mend.io/api/mc/badges/age/docker/mcr.microsoft.com%2fplaywright/v1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/docker/mcr.microsoft.com%2fplaywright/v1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/docker/mcr.microsoft.com%2fplaywright/v1.46.0/v1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/docker/mcr.microsoft.com%2fplaywright/v1.46.0/v1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| final | patch |

---

### Release Notes

<details>
<summary>dequelabs/axe-core-npm (@&#8203;axe-core/playwright)</summary>

###
[`v4.10.0`](https://github.com/dequelabs/axe-core-npm/releases/tag/v4.10.0):
Release 4.10.0

[Compare
Source](https://github.com/dequelabs/axe-core-npm/compare/v4.9.1...v4.10.0)

#### What's Changed

- fix(playwright): Add missing await on page.evaluate by
[@&#8203;KuSh](https://github.com/KuSh) in
[dequelabs/axe-core-npm#1063
- chore: update to support eslint 9 flat config by
[@&#8203;michael-siek](https://github.com/michael-siek) in
[dequelabs/axe-core-npm#1064
- chore: merge master into develop by
[@&#8203;attest-team-ci](https://github.com/attest-team-ci) in
[dequelabs/axe-core-npm#1071
- chore: bump puppeteer from 21.7.0 to 22.10.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1073
- chore: bump sinon from 17.0.1 to 18.0.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1076
- chore: bump chromedriver from 121.0.0 to 125.0.3 by
[@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1075
- chore: fix eslint errors and warnings by
[@&#8203;straker](https://github.com/straker) in
[dequelabs/axe-core-npm#1079
- chore: bump typescript-eslint from 8.0.0-alpha.12 to 8.0.0-alpha.26 by
[@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1078
- chore: bump the npm-low-risk group across 1 directory with 22 updates
by [@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1077
- chore: use updated browser-driver-manager by
[@&#8203;scottmries](https://github.com/scottmries) in
[dequelabs/axe-core-npm#1080
- chore: bump the npm-low-risk group with 27 updates by
[@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1081
- chore: bump chromedriver from 125.0.3 to 126.0.4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[dequelabs/axe-core-npm#1082
- feat: Update axe-core to v4.10.0 by
[@&#8203;attest-team-ci](https://github.com/attest-team-ci) in
[dequelabs/axe-core-npm#1088
- chore: downgrade lerna to resolve ESM requirement by
[@&#8203;michael-siek](https://github.com/michael-siek) in
[dequelabs/axe-core-npm#1098
- fix(cli): include `dotenv` dep by
[@&#8203;michael-siek](https://github.com/michael-siek) in
[dequelabs/axe-core-npm#1103
- chore: RC v4.10.0 by
[@&#8203;github-actions](https://github.com/github-actions) in
[dequelabs/axe-core-npm#1108
- Release 4.10.0 by [@&#8203;dequejenn](https://github.com/dequejenn)
in
[dequelabs/axe-core-npm#1110

#### New Contributors

- [@&#8203;KuSh](https://github.com/KuSh) made their first
contribution in
[dequelabs/axe-core-npm#1063

**Full Changelog**:
dequelabs/axe-core-npm@v4.9.1...v4.10.0

</details>

<details>
<summary>microsoft/playwright (@&#8203;playwright/test)</summary>

###
[`v1.46.1`](https://github.com/microsoft/playwright/compare/v1.46.0...e1c861cfa7a6caf3c5b798786b1e6298c4f3cf31)

[Compare
Source](https://github.com/microsoft/playwright/compare/v1.46.0...v1.46.1)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/ionic-team/ionic-framework).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Sep 10, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zidious Zidious Zidious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @Zidious