-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: work with extremely large results #667
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ import axeCore from 'axe-core'; | |
declare global { | ||
interface Window { | ||
axe: typeof axeCore; | ||
partialResults: string; | ||
} | ||
} | ||
export const axeGetFrameContexts = ({ | ||
|
@@ -36,8 +37,12 @@ export const axeRunPartial = ({ | |
}; | ||
|
||
export const axeFinishRun = ({ | ||
partialResults, | ||
options | ||
}: FinishRunParams): Promise<AxeResults> => { | ||
return window.axe.finishRun(partialResults, options); | ||
return window.axe.finishRun(JSON.parse(window.partialResults), options); | ||
}; | ||
|
||
export function chunkResultString(chunk: string) { | ||
window.partialResults ??= ''; | ||
window.partialResults += chunk; | ||
Comment on lines
+46
to
+47
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What happens if the site under test has this global defined? We should at least prefix this with "axe". There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Intersting, OK 👍 |
||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't
partialResults
be passed in here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the problem. It was too big to be put here on it's own