ci: fix GH release workflow #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
previously requested changes
Oct 16, 2023
.github/workflows/deploy.yml
Outdated
| - run: | | ||
| PKG_VERSION=$(jq -r .version < lerna.json) | ||
| gh release create v$PKG_VERSION \ | ||
| --title "Release v$PKG_VERSION" \ |
There was a problem hiding this comment.
Our github releases do not use the v syntax for releases. Not sure we want to move to doing that now
straker
previously requested changes
Oct 16, 2023
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
straker
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the implemented GHA that cuts a release in GitHub since the GHA requires a git branch to have the tag
refs/tags/and when we cut the release we do not use the version as part of the release processwith the GitHub CLI https://cli.github.com/manual/gh_release_create