refactor: use new test-fixtures path #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
commented
Oct 18, 2023
| @@ -17,6 +17,7 @@ | |||
| "devDependencies": { | |||
| "@typescript-eslint/eslint-plugin": "^5.40.0", | |||
| "@typescript-eslint/parser": "^5.40.0", | |||
| "axe-test-fixtures": "github:dequelabs/axe-test-fixtures#v1", | |||
There was a problem hiding this comment.
This wasn't pinned to v1 so wasn't getting the path update. Also not sure why it was a dependency so made it a dev dependency.
WilcoFiers
previously requested changes
Oct 20, 2023
| @@ -619,7 +616,7 @@ describe('@axe-core/webdriverjs', () => { | |||
| }); | |||
|
|
|||
| it('with chaining include and exclude', async () => { | |||
| await driver.get(`${addr}/context.html`); | |||
| await driver.get(`${addr}/context-include-exclude.html`); | |||
There was a problem hiding this comment.
This test doesn't really prove anything. If you only had the .includes the assertions would still pass because the excludes aren't nested in an include. Not sure that needs to be fixed in this PR, but something should be done about it IMO.
There was a problem hiding this comment.
Yup. Noticed that too. This would fix it dequelabs/axe-test-fixtures#28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new exported
fixturesPathfromaxe-test-fixturesand remove all the symlinks toexternaland allfixturesdirectories.