Skip to content

Commit

Permalink
feat(metadata): update ACT tags & actIds (#3498)
Browse files Browse the repository at this point in the history
* feat(metadata): update ACT tags & actIds

* Remove ACT ID from audio-caption
  • Loading branch information
WilcoFiers authored Jun 3, 2022
1 parent 4685270 commit 571722b
Show file tree
Hide file tree
Showing 28 changed files with 102 additions and 83 deletions.
136 changes: 68 additions & 68 deletions doc/rule-descriptions.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/rules/aria-command-name.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"id": "aria-command-name",
"selector": "[role=\"link\"], [role=\"button\"], [role=\"menuitem\"]",
"matches": "no-naming-method-matches",
"tags": ["cat.aria", "wcag2a", "wcag412"],
"tags": ["cat.aria", "wcag2a", "wcag412", "ACT"],
"actIds": ["97a4e1"],
"metadata": {
"description": "Ensures every ARIA button, link and menuitem has an accessible name",
Expand Down
1 change: 1 addition & 0 deletions lib/rules/aria-required-attr.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"id": "aria-required-attr",
"selector": "[role]",
"tags": ["cat.aria", "wcag2a", "wcag412"],
"actIds": ["4e8ab6"],
"metadata": {
"description": "Ensures elements with ARIA roles have all required ARIA attributes",
"help": "Required ARIA attributes must be provided"
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/aria-required-children.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"selector": "[role]",
"matches": "aria-required-children-matches",
"tags": ["cat.aria", "wcag2a", "wcag131"],
"actIds": ["ff89c9"],
"actIds": ["bc4a75"],
"metadata": {
"description": "Ensures elements with an ARIA role that require child roles contain them",
"help": "Certain ARIA roles must contain particular children"
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/aria-required-parent.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"selector": "[role]",
"matches": "aria-required-parent-matches",
"tags": ["cat.aria", "wcag2a", "wcag131"],
"actIds": ["bc4a75", "ff89c9"],
"actIds": ["ff89c9"],
"metadata": {
"description": "Ensures elements with an ARIA role that require parent roles are contained by them",
"help": "Certain ARIA roles must be contained by particular parents"
Expand Down
1 change: 1 addition & 0 deletions lib/rules/aria-roles.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"selector": "[role]",
"matches": "no-empty-role-matches",
"tags": ["cat.aria", "wcag2a", "wcag412"],
"actIds": ["674b10"],
"metadata": {
"description": "Ensures all elements with a role attribute use a valid value",
"help": "ARIA roles used must conform to valid values"
Expand Down
1 change: 1 addition & 0 deletions lib/rules/aria-toggle-field-name.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"selector": "[role=\"checkbox\"], [role=\"menuitemcheckbox\"], [role=\"menuitemradio\"], [role=\"radio\"], [role=\"switch\"], [role=\"option\"]",
"matches": "no-naming-method-matches",
"tags": ["cat.aria", "wcag2a", "wcag412", "ACT"],
"actIds": ["e086e5"],
"metadata": {
"description": "Ensures every ARIA toggle field has an accessible name",
"help": "ARIA toggle fields must have an accessible name"
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/aria-valid-attr-value.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"id": "aria-valid-attr-value",
"matches": "aria-has-attr-matches",
"tags": ["cat.aria", "wcag2a", "wcag412"],
"actIds": ["5c01ea", "c487ae"],
"actIds": ["6a7281"],
"metadata": {
"description": "Ensures all ARIA attributes have valid values",
"help": "ARIA attributes must conform to valid values"
Expand Down
1 change: 1 addition & 0 deletions lib/rules/aria-valid-attr.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"id": "aria-valid-attr",
"matches": "aria-has-attr-matches",
"tags": ["cat.aria", "wcag2a", "wcag412"],
"actIds": ["5f99a7"],
"metadata": {
"description": "Ensures attributes that begin with aria- are valid ARIA attributes",
"help": "ARIA attributes must conform to valid names"
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/audio-caption.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"section508",
"section508.22.a"
],
"actIds": ["c3232f", "e7aa44"],
"actIds": ["2eb176", "afb423"],
"metadata": {
"description": "Ensures <audio> elements have captions",
"help": "<audio> elements must have a captions track"
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/autocomplete-valid.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "autocomplete-valid",
"matches": "autocomplete-matches",
"tags": ["cat.forms", "wcag21aa", "wcag135"],
"tags": ["cat.forms", "wcag21aa", "wcag135", "ACT"],
"actIds": ["73f2c2"],
"metadata": {
"description": "Ensure the autocomplete attribute is correct and suitable for the form field",
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/avoid-inline-spacing.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"id": "avoid-inline-spacing",
"selector": "[style]",
"tags": ["cat.structure", "wcag21aa", "wcag1412"],
"tags": ["cat.structure", "wcag21aa", "wcag1412", "ACT"],
"actIds": ["24afc2", "9e45ec", "78fd32"],
"metadata": {
"description": "Ensure that text spacing set through style attributes can be adjusted with custom stylesheets",
"help": "Inline text spacing must be adjustable with custom stylesheets"
Expand Down
1 change: 1 addition & 0 deletions lib/rules/bypass.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"section508",
"section508.22.o"
],
"actIds": ["cf77f2", "047fe0", "b40fd1", "3e12e1", "ye5d6e"],
"metadata": {
"description": "Ensures each page has at least one mechanism for a user to bypass navigation and jump straight to the content",
"help": "Page must have means to bypass repeated blocks"
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/color-contrast-enhanced.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"matches": "color-contrast-matches",
"excludeHidden": false,
"enabled": false,
"tags": ["cat.color", "wcag2aaa", "wcag146"],
"tags": ["cat.color", "wcag2aaa", "wcag146", "ACT"],
"actIds": ["09o5cg"],
"metadata": {
"description": "Ensures the contrast between foreground and background colors meets WCAG 2 AAA contrast ratio thresholds",
"help": "Elements must have sufficient color contrast"
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/color-contrast.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"id": "color-contrast",
"matches": "color-contrast-matches",
"excludeHidden": false,
"tags": ["cat.color", "wcag2aa", "wcag143"],
"tags": ["cat.color", "wcag2aa", "wcag143", "ACT"],
"actIds": ["afw4f7"],
"metadata": {
"description": "Ensures the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds",
"help": "Elements must have sufficient color contrast"
Expand Down
1 change: 1 addition & 0 deletions lib/rules/duplicate-id-active.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"matches": "duplicate-id-active-matches",
"excludeHidden": false,
"tags": ["cat.parsing", "wcag2a", "wcag411"],
"actIds": ["3ea0c8"],
"metadata": {
"description": "Ensures every id attribute value of active elements is unique",
"help": "IDs of active elements must be unique"
Expand Down
1 change: 1 addition & 0 deletions lib/rules/duplicate-id.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"matches": "duplicate-id-misc-matches",
"excludeHidden": false,
"tags": ["cat.parsing", "wcag2a", "wcag411"],
"actIds": ["3ea0c8"],
"metadata": {
"description": "Ensures every id attribute value is unique",
"help": "id attribute value must be unique"
Expand Down
1 change: 1 addition & 0 deletions lib/rules/empty-heading.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"selector": "h1, h2, h3, h4, h5, h6, [role=\"heading\"]",
"matches": "heading-matches",
"tags": ["cat.name-role-value", "best-practice"],
"actIds": ["ffd0e9"],
"impact": "minor",
"metadata": {
"description": "Ensures headings have discernible text",
Expand Down
1 change: 1 addition & 0 deletions lib/rules/frame-focusable-content.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"selector": "html",
"matches": "frame-focusable-content-matches",
"tags": ["cat.keyboard", "wcag2a", "wcag211"],
"actIds": ["akn7bn"],
"metadata": {
"description": "Ensures <frame> and <iframe> elements with focusable content do not have tabindex=-1",
"help": "Frames with focusable content must not have tabindex=-1"
Expand Down
1 change: 1 addition & 0 deletions lib/rules/frame-title-unique.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"selector": "frame[title], iframe[title]",
"matches": "frame-title-has-text-matches",
"tags": ["cat.text-alternatives", "best-practice"],
"actIds": ["4b1c6c"],
"metadata": {
"description": "Ensures <iframe> and <frame> elements contain a unique title attribute",
"help": "Frames should have a unique title attribute"
Expand Down
1 change: 1 addition & 0 deletions lib/rules/frame-title.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"section508",
"section508.22.i"
],
"actIds": ["cae760"],
"metadata": {
"description": "Ensures <iframe> and <frame> elements have an accessible name",
"help": "Frames must have an accessible name"
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/identical-links-same-purpose.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"excludeHidden": false,
"matches": "identical-links-same-purpose-matches",
"tags": ["cat.semantics", "wcag2aaa", "wcag249"],
"actIds": ["b20e66", "fd3a94"],
"actIds": ["b20e66"],
"metadata": {
"description": "Ensure that links with the same accessible name serve a similar purpose",
"help": "Links with the same name must have a similar purpose"
Expand Down
4 changes: 3 additions & 1 deletion lib/rules/input-button-name.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
"wcag2a",
"wcag412",
"section508",
"section508.22.a"
"section508.22.a",
"ACT"
],
"actIds": ["97a4e1"],
"metadata": {
"description": "Ensures input buttons have discernible text",
"help": "Input buttons must have discernible text"
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/label.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"section508.22.n",
"ACT"
],
"actIds": ["e086e5", "307n5z"],
"actIds": ["e086e5"],
"metadata": {
"description": "Ensures every form element has a label",
"help": "Form elements must have labels"
Expand Down
1 change: 1 addition & 0 deletions lib/rules/meta-refresh.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"wcag224",
"wcag325"
],
"actIds": ["bc659a"],
"metadata": {
"description": "Ensures <meta http-equiv=\"refresh\"> is not used",
"help": "Timed refresh must not exist"
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/no-autoplay-audio.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"excludeHidden": false,
"selector": "audio[autoplay], video[autoplay]",
"matches": "no-autoplay-audio-matches",
"tags": ["cat.time-and-media", "wcag2a", "wcag142", "experimental"],
"tags": ["cat.time-and-media", "wcag2a", "wcag142", "experimental", "ACT"],
"actIds": ["80f0bf"],
"metadata": {
"description": "Ensures <video> or <audio> elements do not autoplay audio for more than 3 seconds without a control mechanism to stop or mute the audio",
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/presentation-role-conflict.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"id": "presentation-role-conflict",
"matches": "has-implicit-chromium-role-matches",
"selector": "[role=\"none\"], [role=\"presentation\"]",
"tags": ["cat.aria", "best-practice"],
"tags": ["cat.aria", "best-practice", "ACT"],
"actIds": ["46ca7f"],
"metadata": {
"description": "Flags elements whose role is none or presentation and which cause the role conflict resolution to trigger.",
"help": "Elements of role none or presentation should be flagged"
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/valid-lang.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"id": "valid-lang",
"selector": "[lang], [xml\\:lang]",
"matches": "not-html-matches",
"tags": ["cat.language", "wcag2aa", "wcag312"],
"tags": ["cat.language", "wcag2aa", "wcag312", "ACT"],
"actIds": ["de46e4"],
"metadata": {
"description": "Ensures lang attributes have valid values",
"help": "lang attribute must have a valid value"
Expand Down

0 comments on commit 571722b

Please sign in to comment.