Skip to content

Commit

Permalink
fix(aria-hidden-focus): Update rule help & description (#3422)
Browse files Browse the repository at this point in the history
* Update `help` value to include focusable elements

The current `help` value does not include the scenario in which `aria-hidden="true"` is on a focusable element. I updated it to include that scenario. Here's the PR, per Wilco's suggestion. Slack thread: https://deque.slack.com/archives/C0LA5E545/p1646762357136919

* Update lib/rules/aria-hidden-focus.json

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
  • Loading branch information
2 people authored and straker committed May 12, 2022
1 parent 222fdef commit 7cfb4b1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/rules/aria-hidden-focus.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"tags": ["cat.name-role-value", "wcag2a", "wcag412", "wcag131"],
"actIds": ["6cfa84"],
"metadata": {
"description": "Ensures aria-hidden elements do not contain focusable elements",
"help": "ARIA hidden element must not contain focusable elements"
"description": "Ensures aria-hidden elements are not focusable nor contain focusable elements",
"help": "ARIA hidden element must not be focusable or contain focusable elements"
},
"all": [
"focusable-modal-open",
Expand Down

0 comments on commit 7cfb4b1

Please sign in to comment.