-
Notifications
You must be signed in to change notification settings - Fork 776
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tests: add test for svg-img-alt for serial nodes (#2401)
* tests: add test for svg-img-alt for serial nodes * typo
- Loading branch information
Showing
3 changed files
with
179 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
import visibleVirtual from '../../commons/text/visible-virtual'; | ||
|
||
function svgNonEmptyTitleEvaluate(node, options, virtualNode) { | ||
if (!virtualNode.children) { | ||
try { | ||
const titleNode = virtualNode.children.find(({ props }) => { | ||
return props.nodeName === 'title'; | ||
}); | ||
return !!titleNode && visibleVirtual(titleNode) !== ''; | ||
} catch (e) { | ||
return undefined; | ||
} | ||
|
||
const titleNode = virtualNode.children.find(({ props }) => { | ||
return props.nodeName === 'title'; | ||
}); | ||
return !!titleNode && visibleVirtual(titleNode) !== ''; | ||
} | ||
|
||
export default svgNonEmptyTitleEvaluate; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,172 @@ | ||
describe('svg-img-alt', function() { | ||
it('should pass for aria-label', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'svg', | ||
attributes: { | ||
role: 'img', | ||
'aria-label': 'foobar' | ||
} | ||
}); | ||
|
||
var results = axe.runVirtualRule('svg-img-alt', node); | ||
|
||
assert.lengthOf(results.passes, 1); | ||
assert.lengthOf(results.violations, 0); | ||
assert.lengthOf(results.incomplete, 0); | ||
}); | ||
|
||
it('should incomplete for aria-labelledby', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'svg', | ||
attributes: { | ||
role: 'graphics-document', | ||
'aria-labelledby': 'foobar' | ||
} | ||
}); | ||
|
||
var results = axe.runVirtualRule('svg-img-alt', node); | ||
|
||
assert.lengthOf(results.passes, 0); | ||
assert.lengthOf(results.violations, 0); | ||
assert.lengthOf(results.incomplete, 1); | ||
}); | ||
|
||
it('should pass for title', function() { | ||
var parent = new axe.SerialVirtualNode({ | ||
nodeName: 'svg' | ||
}); | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'circle', | ||
attributes: { | ||
role: 'graphics-symbol', | ||
title: 'foobar' | ||
} | ||
}); | ||
|
||
// children are required since titleText comes after subtree text | ||
// in accessible name calculation | ||
node.children = []; | ||
node.parent = parent; | ||
parent.children = [node]; | ||
|
||
var results = axe.runVirtualRule('svg-img-alt', node); | ||
|
||
assert.lengthOf(results.passes, 1); | ||
assert.lengthOf(results.violations, 0); | ||
assert.lengthOf(results.incomplete, 0); | ||
}); | ||
|
||
it('should pass for title element', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'svg', | ||
attributes: { | ||
role: 'img' | ||
} | ||
}); | ||
var title = new axe.SerialVirtualNode({ | ||
nodeName: 'title' | ||
}); | ||
var text = new axe.SerialVirtualNode({ | ||
nodeName: '#text', | ||
nodeType: 3, | ||
nodeValue: 'foobar' | ||
}); | ||
|
||
title.children = [text]; | ||
title.parent = node; | ||
node.children = [title]; | ||
|
||
var results = axe.runVirtualRule('svg-img-alt', node); | ||
|
||
assert.lengthOf(results.passes, 1); | ||
assert.lengthOf(results.violations, 0); | ||
assert.lengthOf(results.incomplete, 0); | ||
}); | ||
|
||
it('should incomplete when aria-label and children are missing', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'svg', | ||
attributes: { | ||
role: 'img' | ||
} | ||
}); | ||
|
||
var results = axe.runVirtualRule('svg-img-alt', node); | ||
|
||
assert.lengthOf(results.passes, 0); | ||
assert.lengthOf(results.violations, 0); | ||
assert.lengthOf(results.incomplete, 1); | ||
}); | ||
|
||
it('should fail when aria-label contains only whitespace', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'svg', | ||
attributes: { | ||
role: 'img', | ||
'aria-label': ' \t \n ' | ||
} | ||
}); | ||
node.children = []; | ||
|
||
var results = axe.runVirtualRule('svg-img-alt', node); | ||
|
||
assert.lengthOf(results.passes, 0); | ||
assert.lengthOf(results.violations, 1); | ||
assert.lengthOf(results.incomplete, 0); | ||
}); | ||
|
||
it('should fail when aria-label is empty', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'svg', | ||
attributes: { | ||
role: 'img', | ||
'aria-label': '' | ||
} | ||
}); | ||
node.children = []; | ||
|
||
var results = axe.runVirtualRule('svg-img-alt', node); | ||
|
||
assert.lengthOf(results.passes, 0); | ||
assert.lengthOf(results.violations, 1); | ||
assert.lengthOf(results.incomplete, 0); | ||
}); | ||
|
||
it('should fail when title is empty', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'svg', | ||
attributes: { | ||
role: 'img', | ||
title: '' | ||
} | ||
}); | ||
node.children = []; | ||
|
||
var results = axe.runVirtualRule('svg-img-alt', node); | ||
|
||
assert.lengthOf(results.passes, 0); | ||
assert.lengthOf(results.violations, 1); | ||
assert.lengthOf(results.incomplete, 0); | ||
}); | ||
|
||
it('should incomplete when title element has missing children', function() { | ||
var node = new axe.SerialVirtualNode({ | ||
nodeName: 'svg', | ||
attributes: { | ||
role: 'img' | ||
} | ||
}); | ||
var title = new axe.SerialVirtualNode({ | ||
nodeName: 'title' | ||
}); | ||
|
||
title.parent = node; | ||
node.children = [title]; | ||
|
||
var results = axe.runVirtualRule('svg-img-alt', node); | ||
|
||
assert.lengthOf(results.passes, 0); | ||
assert.lengthOf(results.violations, 0); | ||
assert.lengthOf(results.incomplete, 1); | ||
}); | ||
}); |