Skip to content

Commit

Permalink
fix(aria): Updating aria 1.1 allowed attributes (#964)
Browse files Browse the repository at this point in the history
  • Loading branch information
@iamrafan @WilcoFiers
iamrafan authored and WilcoFiers committed Jun 24, 2018
1 parent df208d8 commit c3249c1
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
14 changes: 7 additions & 7 deletions lib/commons/aria/index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ lookupTable.role = {
'checkbox': {
type: 'widget',
attributes: {
allowed: ['aria-checked', 'aria-required']
allowed: ['aria-checked', 'aria-required', 'aria-readonly']
},
owned: null,
nameFrom: ['author', 'contents'],
Expand Down Expand Up @@ -960,7 +960,7 @@ lookupTable.role = {
'progressbar': {
type: 'widget',
attributes: {
allowed: ['aria-valuetext', 'aria-valuenow', 'aria-valuemax', 'aria-valuemin']
allowed: ['aria-valuetext', 'aria-valuenow', 'aria-valuemax', 'aria-valuemin','aria-expanded']
},
owned: null,
nameFrom: ['author'],
Expand All @@ -980,7 +980,7 @@ lookupTable.role = {
'radiogroup': {
type: 'composite',
attributes: {
allowed: ['aria-activedescendant', 'aria-required', 'aria-expanded']
allowed: ['aria-activedescendant', 'aria-required', 'aria-expanded', 'aria-readonly']
},
owned: {
all: ['radio']
Expand Down Expand Up @@ -1085,7 +1085,7 @@ lookupTable.role = {
'separator': {
type: 'structure',
attributes: {
allowed: ['aria-expanded', 'aria-orientation']
allowed: ['aria-expanded', 'aria-orientation', 'aria-valuenow', 'aria-valuemax','aria-valuemin', 'aria-valuetext']
},
owned: null,
nameFrom: ['author'],
Expand All @@ -1095,7 +1095,7 @@ lookupTable.role = {
'slider': {
type: 'widget',
attributes: {
allowed: ['aria-valuetext', 'aria-orientation'],
allowed: ['aria-valuetext', 'aria-orientation', 'aria-readonly'],
required: ['aria-valuenow', 'aria-valuemax', 'aria-valuemin']
},
owned: null,
Expand All @@ -1106,7 +1106,7 @@ lookupTable.role = {
'spinbutton': {
type: 'widget',
attributes: {
allowed: ['aria-valuetext', 'aria-required'],
allowed: ['aria-valuetext', 'aria-required', 'aria-readonly'],
required: ['aria-valuenow', 'aria-valuemax', 'aria-valuemin']
},
owned: null,
Expand Down Expand Up @@ -1217,7 +1217,7 @@ lookupTable.role = {
'toolbar': {
type: 'structure',
attributes: {
allowed: ['aria-activedescendant', 'aria-expanded']
allowed: ['aria-activedescendant', 'aria-expanded', 'aria-orientation']
},
owned: null,
nameFrom: ['author'],
Expand Down
14 changes: 7 additions & 7 deletions test/integration/rules/aria-allowed-attr/passes.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<div role="button" id="pass6" aria-expanded="value" aria-pressed="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>

<div role="checkbox" id="pass7" aria-checked="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>
<div role="checkbox" id="pass7" aria-checked="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value" aria-readonly="value">ok</div>

<div role="columnheader" id="pass8" aria-colindex="value" aria-colspan="value" aria-expanded="value" aria-rowindex="value" aria-rowspan="value" aria-sort="value" aria-readonly="value" aria-selected="value" aria-required="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>

Expand Down Expand Up @@ -77,11 +77,11 @@

<div role="option" id="pass38" aria-selected="value" aria-posinset="value" aria-setsize="value" aria-checked="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>

<div role="progressbar" id="pass39" aria-valuetext="value" aria-valuenow="value" aria-valuemax="value" aria-valuemin="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>
<div role="progressbar" id="pass39" aria-valuetext="value" aria-valuenow="value" aria-valuemax="value" aria-valuemin="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value" aria-expanded="value">ok</div>

<div role="radio" id="pass40" aria-selected="value" aria-posinset="value" aria-setsize="value" aria-checked="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>

<div role="radiogroup" id="pass41" aria-activedescendant="value" aria-required="value" aria-expanded="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>
<div role="radiogroup" id="pass41" aria-activedescendant="value" aria-required="value" aria-expanded="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value" aria-readonly="value">ok</div>

<div role="region" id="pass42" aria-expanded="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>

Expand All @@ -95,11 +95,11 @@

<div role="search" id="pass47" aria-expanded="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>

<div role="separator" id="pass48" aria-expanded="value" aria-orientation="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>
<div role="separator" id="pass48" aria-expanded="value" aria-orientation="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value" aria-valuenow="value" aria-valuemax="value" aria-valuemin="value" aria-valuetext="value">ok</div>

<div role="slider" id="pass49" aria-valuetext="value" aria-orientation="value" aria-valuenow="value" aria-valuemax="value" aria-valuemin="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>
<div role="slider" id="pass49" aria-valuetext="value" aria-orientation="value" aria-valuenow="value" aria-valuemax="value" aria-valuemin="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value" aria-readonly="value">ok</div>

<div role="spinbutton" id="pass50" aria-valuetext="value" aria-required="value" aria-valuenow="value" aria-valuemax="value" aria-valuemin="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>
<div role="spinbutton" id="pass50" aria-valuetext="value" aria-required="value" aria-valuenow="value" aria-valuemax="value" aria-valuemin="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value" aria-readonly="value">ok</div>

<div role="status" id="pass51" aria-expanded="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>

Expand All @@ -113,7 +113,7 @@

<div role="timer" id="pass56" aria-expanded="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>

<div role="toolbar" id="pass57" aria-activedescendant="value" aria-expanded="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>
<div role="toolbar" id="pass57" aria-activedescendant="value" aria-expanded="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value" aria-orientation="value">ok</div>

<div role="tooltip" id="pass58" aria-expanded="value" aria-atomic="value" aria-busy="value" aria-controls="value" aria-describedby="value" aria-disabled="value" aria-dropeffect="value" aria-flowto="value" aria-grabbed="value" aria-haspopup="value" aria-hidden="value" aria-invalid="value" aria-keyshortcuts="value" aria-label="value" aria-labelledby="value" aria-live="value" aria-owns="value" aria-relevant="value">ok</div>

Expand Down

0 comments on commit c3249c1

Please sign in to comment.