fix: Allow title on button-name (#794)

Closes #747 Closes #765
dequelabs · Mar 28, 2018 · e31fe9a · e31fe9a
1 parent f5afadb
commit e31fe9a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/lib/rules/button-name.json b/lib/rules/button-name.json
@@ -20,7 +20,8 @@
     "aria-label",
     "aria-labelledby",
     "role-presentation",
-    "role-none"
+    "role-none",
+    "non-empty-title"
   ],
   "none": [
     "focusable-no-name"

diff --git a/test/integration/rules/button-name/button-name.html b/test/integration/rules/button-name/button-name.html
@@ -10,3 +10,5 @@
 <div id="labeldiv">Button label</div>
 <div id="emptydiv"></div>
 <button id="combo" aria-label="Aria Name">Name</button>
+<button id="buttonTitle" title="Title"></button>
+<input id="inputTitle" title="Search" type="button">
diff --git a/test/integration/rules/button-name/button-name.json b/test/integration/rules/button-name/button-name.json
@@ -2,5 +2,5 @@
 	"description": "button-name test",
 	"rule": "button-name",
 	"violations": [["#empty"], ["#val"], ["#alempty"], ["#albmissing"], ["#albempty"]],
-	"passes": [["#text"], ["#al"], ["#alb"], ["#combo"]]
+	"passes": [["#text"], ["#al"], ["#alb"], ["#combo"], ["#buttonTitle"], ["#inputTitle"]]
 }