Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

false positive: input type="button" with @title only #747

Closed
jasonkiss opened this issue Feb 28, 2018 · 1 comment
Closed

false positive: input type="button" with @title only #747

jasonkiss opened this issue Feb 28, 2018 · 1 comment

Comments

@jasonkiss
Copy link

<input type="button" title="Search"> currently fails the "Buttons must have discernible text" test, but the title attribute is a permitted source for programmatically calculating the element's accessible name, as per the HTML-AAM.
@WilcoFiers WilcoFiers mentioned this issue Mar 8, 2018
Closed
@marcysutton
Copy link
Contributor

I wonder if it was written that way for historical reasons, since title wasn't always exposed. In any case, we have a similar issue open for messaging (#765) and will look into a fix.

marcysutton pushed a commit that referenced this issue Mar 20, 2018
fix: allow title on button-name
0ab1bc4 
Closes #747
Closes #765
@marcysutton marcysutton mentioned this issue Mar 20, 2018
Merged
WilcoFiers pushed a commit that referenced this issue Mar 28, 2018
@marcysutton @WilcoFiers
fix: Allow title on button-name (#794)
e31fe9a 
Closes #747
Closes #765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonkiss @marcysutton