-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aria-required-children violation on role=combobox not valid #1009
Comments
Fair point. Have you done any testing with assistive technologies to see how well this is supported? I think we'd need to do that first. @Keerthi-Penukonda do you think you could do some testing for us with this? |
@WilcoFiers , tested the given code snippet with role="listbox" and also with role="grid". In both the cases screen reader behavior is same.
|
We need to test all of the combinations in our support matrix, there are a few more: https://github.com/dequelabs/axe-core/blob/develop/doc/accessibility-supported.md |
Below are the screen reader behaviors with different combinations: JAWS and IE on Windows:
NVDA and FF on Windows:
VO in Safari on MAC:
VO in Safari on IOS:
TalkBack in Chrome on Android:
Note: I have not tested with Dragon as I have not worked with it earlier. I will ask any of the SME's who knows 'Dragon' and will update the screen behavior later. |
+1 We also need support for |
Release notes updated as of 2/03/2020 |
Working for axe-core, will verify the same with axe and attest extensions once axe-core3.5 deployed in devTools. |
Hello, I would like to raise an issue around the
aria-required-children
violation.Consider the following example:
When I run an aXe test on the above set of elements, the test would fail because of a violation of the
aria-required-children
check. The details reveal that the check failed because the<input>
, having being defined withrole="combobox"
, must have a child withrole="listbox"
.However, according to the WAI-ARIA guidelines for comboboxes, we can see that aside from
listbox
, there are three other permitted children roles:tree
,grid
, anddialog
. The above example satisfies this condition because thecombobox
specifies its popup as being agrid
and usesaria-owns
to point to the specificgrid
tied to thiscombobox
.Looking at the role lookup table inside of the aXe engine, there are no provisions for these alternatives under the
combobox
section. If I am interpreting the WAI-ARIA guidelines correctly, then I believe this should be updated.The text was updated successfully, but these errors were encountered: