fix(aria-required-children): allow comboboxes with more popup roles #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdnoC
force-pushed
the
allowed-combobox-popups
branch
2 times, most recently
from
00b4059
to
8ec657c
Compare
AdnoC
force-pushed
the
allowed-combobox-popups
branch
from
8ec657c
to
8a9c7b6
Compare
AdnoC
changed the title
WilcoFiers
previously requested changes
Dec 20, 2019
| for (let index = 0; index < expandedChildRoles.length; index++) { | ||
| const expandedChildRole = expandedChildRoles[index]; | ||
| // keep the specified popup type required if expanded | ||
| if (expanded && expandedChildRole === popupRole) { |
There was a problem hiding this comment.
should probably make this case insensitive.
WilcoFiers
previously requested changes
Dec 20, 2019
| const popupRole = node.getAttribute('aria-haspopup') || 'listbox'; | ||
| const popupRole = ( | ||
| node.getAttribute('aria-haspopup') || 'listbox' | ||
| ).toLowerCase(); |
jeeyyy
previously requested changes
Dec 31, 2019
There was a problem hiding this comment.
@AdnoC looks like this comment was not addressed - https://github.com/dequelabs/axe-core/pull/1950/files#r360322055
AdnoC
dismissed
jeeyyy’s stale review
The popup attribute text is made lowercase, causing the comparison to be case insensitive: https://github.com/dequelabs/axe-core/pull/1950/files#diff-5b800295554e9fa19a69589b10125fcfR83
WilcoFiers
approved these changes
Jan 6, 2020
WilcoFiers
previously requested changes
Jan 6, 2020
WilcoFiers
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the other allowed expanded child types to the
comboboxowned requirements. If the box is open it checks what the expected role of the expanded element should be and only makes that required. If the box is closed it doesn't make any of them required.Also modernized the rest of the file (
var->letorconst)Closes issue: #1009
Reviewer checks
Required fields, to be filled out by PR reviewer(s)