Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aria-required-children): allow comboboxes with more popup roles #1950

Merged
merged 5 commits into from
Jan 6, 2020
Merged

fix(aria-required-children): allow comboboxes with more popup roles #1950

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bcf6150
fix(aria-required-children): allow comboboxes with more popup roles
AdnoC Dec 18, 2019
8a9c7b6
chore: modernize aria-required-children check file
AdnoC Dec 18, 2019
6e9dc6f
lowercase popup role
AdnoC Dec 20, 2019
0fc146c
test default
AdnoC Dec 24, 2019
60aaa6a
case test
AdnoC Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/checks/aria/required-children.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ function missingRequiredChildren(node, childRoles, all, role) {
const expandedChildRoles = ['listbox', 'tree', 'grid', 'dialog'];
const expandedValue = node.getAttribute('aria-expanded');
const expanded = expandedValue && expandedValue !== 'false';
const popupRole = node.getAttribute('aria-haspopup') || 'listbox';
const popupRole = (
node.getAttribute('aria-haspopup') || 'listbox'
).toLowerCase();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test this too.


for (let index = 0; index < expandedChildRoles.length; index++) {
const expandedChildRole = expandedChildRoles[index];
Expand Down