Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: tests with external stylesheets (PR #1132) #1086

Closed
jeeyyy opened this issue Aug 21, 2018 · 2 comments
Closed

Refactor: tests with external stylesheets (PR #1132) #1086

jeeyyy opened this issue Aug 21, 2018 · 2 comments
Assignees
@jeeyyy
Labels
feat New feature or enhancement

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Aug 21, 2018

  • For tests where style sheets are dynamically injected, best to register a listener for onload of the link, rather than a pre-defined timeout in the before hook.

Eg:
https://github.com/dequelabs/axe-core/pull/1081/files#diff-c0f62bc557a8659e4c82840ca388ee9aR39
@jeeyyy jeeyyy self-assigned this Aug 21, 2018
@jeeyyy jeeyyy mentioned this issue Aug 21, 2018
Merged
4 tasks
@jeeyyy jeeyyy added the feat New feature or enhancement label Aug 23, 2018
@jeeyyy jeeyyy mentioned this issue Sep 12, 2018
Closed
4 tasks
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Sep 12, 2018

PR - #1131

@jeeyyy jeeyyy changed the title Refactor: tests with external stylesheets Refactor: tests with external stylesheets (PR #1131) Sep 12, 2018
@jeeyyy jeeyyy mentioned this issue Sep 12, 2018
Merged
4 tasks
@jeeyyy jeeyyy changed the title Refactor: tests with external stylesheets (PR #1131) Refactor: tests with external stylesheets (PR #1132) Oct 10, 2018
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Nov 2, 2018

PR #1132 merged. Closing issue.

@jeeyyy jeeyyy closed this as completed Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeeyyy jeeyyy

Labels
feat New feature or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeeyyy