refactor: onload listener for stylesheets in before hook of tests #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeyyy
changed the title
WilcoFiers
reviewed
Oct 2, 2018
| }) | ||
| .catch(function(error) { | ||
| console.error('Could not load stylesheets for testing.', error); | ||
| done(); |
There was a problem hiding this comment.
Seems like this should cause the tests to fail.
WilcoFiers
reviewed
Oct 2, 2018
| }) | ||
| .catch(function(error) { | ||
| console.error('Could not load stylesheets for testing.', error); | ||
| done(); |
There was a problem hiding this comment.
Same here, if injecting fails, the before hook should fail.
WilcoFiers
previously requested changes
Oct 15, 2018
test/testutils.js
Outdated
| promises.push(p); | ||
| }); | ||
|
|
||
| return Promise.all(promises); |
jeeyyy
changed the title
jeeyyy
changed the title
|
Usage of |
stephenmathieson
approved these changes
Oct 30, 2018
WilcoFiers
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
addStyleSheethelper for CSSOM based tests intoaxe.testUtilsobject. The function also returns a promise, thereby allowing to wait until the stylesheets are loaded in thebeforehook, thus ensuring assets are available before running respective tests.Closes issue:
Reviewer checks
Required fields, to be filled out by PR reviewer(s)