Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests to ensure build generated files exist (PR #1133) #1117

Closed
jeeyyy opened this issue Aug 30, 2018 · 1 comment
Closed

Tests to ensure build generated files exist (PR #1133) #1117

jeeyyy opened this issue Aug 30, 2018 · 1 comment
Assignees
@jeeyyy

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Aug 30, 2018

Add some test cases to ensure, build generated files exist in axe-core.
@jeeyyy jeeyyy self-assigned this Aug 30, 2018
@jeeyyy jeeyyy mentioned this issue Aug 30, 2018
Merged
4 tasks
@jeeyyy jeeyyy changed the title Tests fo ensure build generated files exist Tests to ensure build generated files exist Aug 31, 2018
@jeeyyy jeeyyy mentioned this issue Sep 12, 2018
Merged
4 tasks
@jeeyyy jeeyyy changed the title Tests to ensure build generated files exist Tests to ensure build generated files exist (PR #1133) Sep 12, 2018
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Sep 12, 2018

PR - #1133

WilcoFiers pushed a commit that referenced this issue Sep 26, 2018
@jeeyyy @WilcoFiers
chore: Ensure generated files exist (#1133)
ae2e093 
This PR introduces a new task which ensures, existence of a given set of files. In this case it checks, for `axe.***.js` files for all langs specified. If the build generated files do not exist, a fatal error is thrown. Also, the same files are checked for existence as a part of `prepublishOnly` step.


<img width="504" alt="screen shot 2018-09-12 at 08 54 26" src="https://user-images.githubusercontent.com/20978252/45410410-85f44680-b669-11e8-9649-8d02dc4bb3df.png">


Closes issue:
- #1117

## Reviewer checks

**Required fields, to be filled out by PR reviewer(s)**
- [x] Follows the commit message policy, appropriate for next version
- [x] Has documentation updated, a DU ticket, or requires no documentation change
- [x] Includes new tests, or was unnecessary
- [x] Code is reviewed for security by: @WilcoFiers
@jeeyyy jeeyyy closed this as completed Oct 10, 2018
Danidude pushed a commit to tingtun/axe-core that referenced this issue Nov 1, 2018
@jeeyyy
chore: Ensure generated files exist (dequelabs#1133)
8eb74cc 
This PR introduces a new task which ensures, existence of a given set of files. In this case it checks, for `axe.***.js` files for all langs specified. If the build generated files do not exist, a fatal error is thrown. Also, the same files are checked for existence as a part of `prepublishOnly` step.


<img width="504" alt="screen shot 2018-09-12 at 08 54 26" src="https://user-images.githubusercontent.com/20978252/45410410-85f44680-b669-11e8-9649-8d02dc4bb3df.png">


Closes issue:
- dequelabs#1117

## Reviewer checks

**Required fields, to be filled out by PR reviewer(s)**
- [x] Follows the commit message policy, appropriate for next version
- [x] Has documentation updated, a DU ticket, or requires no documentation change
- [x] Includes new tests, or was unnecessary
- [x] Code is reviewed for security by: @WilcoFiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeeyyy jeeyyy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WilcoFiers @jeeyyy